zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

DataChannelInterface: Remove default implementation of methods.

Browse Source 
This can land as soon as https://codereview.chromium.org/2520033005/ has
landed.

BUG=chromium:654927

Review-Url: https://codereview.webrtc.org/2524033002
Cr-Commit-Position: refs/heads/master@{#15221}
This commit is contained in:
hbos
2016-11-24 01:17:52 -08:00
committed by Commit bot
parent 464d50f293
commit c42d37646f
1 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
webrtc/api/datachannelinterface.h
View File

@ -125,13 +125,10 @@ class DataChannelInterface : public rtc::RefCountInterface {
virtual int id() const = 0;
virtual DataState state() const = 0;
// TODO(hbos): Default implementations of [messages/bytes]_[sent/received] as
// to not break Chromium. Fix Chromium's implementation as soon as this rolls.
// crbug.com/654927
virtual uint32_t messages_sent() const { return 0; }
virtual uint64_t bytes_sent() const { return 0; }
virtual uint32_t messages_received() const { return 0; }
virtual uint64_t bytes_received() const { return 0; }
virtual uint32_t messages_sent() const = 0;
virtual uint64_t bytes_sent() const = 0;
virtual uint32_t messages_received() const = 0;
virtual uint64_t bytes_received() const = 0;
// The buffered_amount returns the number of bytes of application data
// (UTF-8 text and binary data) that have been queued using SendBuffer but
// have not yet been transmitted to the network.