Blacklist "build/c++11" cpplint filter.
This CL removes "build/c++11" from the cpplint filters. The same was changed in "depot_tools" in https://codereview.chromium.org/1573663003/ From the other CL: ----- The checks are not reliable for Rvalue references, and only are allowing default/deleted constructors. They are based on the google3 internal rules which do not exactly match our own c++11 rules, and may diverge more over time. ----- NOTRY=True Review URL: https://codereview.webrtc.org/1710293002 Cr-Commit-Position: refs/heads/master@{#11678}
This commit is contained in:
15
PRESUBMIT.py
15
PRESUBMIT.py
@ -31,6 +31,17 @@ CPPLINT_DIRS = [
|
||||
'webrtc/video',
|
||||
]
|
||||
|
||||
# These filters will always be removed, even if the caller specifies a filter
|
||||
# set, as they are problematic or broken in some way.
|
||||
#
|
||||
# Justifications for each filter:
|
||||
# - build/c++11 : Rvalue ref checks are unreliable (false positives),
|
||||
# include file and feature blacklists are
|
||||
# google3-specific.
|
||||
BLACKLIST_LINT_FILTERS = [
|
||||
'-build/c++11',
|
||||
]
|
||||
|
||||
# List of directories of "supported" native APIs. That means changes to headers
|
||||
# will be done in a compatible way following this scheme:
|
||||
# 1. Non-breaking changes are made.
|
||||
@ -172,6 +183,10 @@ def _CheckApprovedFilesLintClean(input_api, output_api,
|
||||
# pylint: disable=W0212
|
||||
cpplint._cpplint_state.ResetErrorCounts()
|
||||
|
||||
lint_filters = cpplint._Filters()
|
||||
lint_filters.extend(BLACKLIST_LINT_FILTERS)
|
||||
cpplint._SetFilters(','.join(lint_filters))
|
||||
|
||||
# Create a platform independent whitelist for the CPPLINT_DIRS.
|
||||
whitelist_dirs = [input_api.os_path.join(*path.split('/'))
|
||||
for path in CPPLINT_DIRS]
|
||||
|
Reference in New Issue
Block a user