zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete classes EventFactory and EventFactoryImpl.

Browse Source 
Followup to cl https://webrtc-review.googlesource.com/c/src/+/107890

Bug: webrtc:3380
Change-Id: Iac4389186be3ffbc55e53e18aa302465cd771da4
Reviewed-on: https://webrtc-review.googlesource.com/c/110140
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25559}
This commit is contained in:
Niels Möller
2018-11-08 13:08:26 +01:00
committed by Commit Bot
parent 2a74263e3f
commit c4e9825c04
2 changed files with 1 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
modules/video_coding/include/video_coding.h
View File

@ -38,21 +38,6 @@ class VideoDecoder;
class VideoEncoder; class VideoEncoder;
struct CodecSpecificInfo; struct CodecSpecificInfo;
// DEPRECATED
class EventFactory {
public:
virtual ~EventFactory() {}
virtual EventWrapper* CreateEvent() = 0;
};
class RTC_DEPRECATED EventFactoryImpl : public EventFactory {
public:
~EventFactoryImpl() override {}
EventWrapper* CreateEvent() override;
};
// Used to indicate which decode with errors mode should be used. // Used to indicate which decode with errors mode should be used.
enum VCMDecodeErrorMode { enum VCMDecodeErrorMode {
kNoErrors, // Never decode with errors. Video will freeze kNoErrors, // Never decode with errors. Video will freeze
@ -70,11 +55,6 @@ class VideoCodingModule : public Module {
public: public:
enum SenderNackMode { kNackNone, kNackAll, kNackSelective }; enum SenderNackMode { kNackNone, kNackAll, kNackSelective };
RTC_DEPRECATED
static VideoCodingModule* Create(Clock* clock,
EventFactory* /* event_factory*/) {
return Create(clock);
}
// DEPRECATED. // DEPRECATED.
static VideoCodingModule* Create(Clock* clock); static VideoCodingModule* Create(Clock* clock);

7
modules/video_coding/video_coding_impl.cc
View File

@ -27,10 +27,6 @@
#include "system_wrappers/include/clock.h" #include "system_wrappers/include/clock.h"
namespace webrtc { namespace webrtc {
EventWrapper* EventFactoryImpl::CreateEvent() {
return EventWrapper::Create();
}
namespace vcm { namespace vcm {
int64_t VCMProcessTimer::Period() const { int64_t VCMProcessTimer::Period() const {
@ -81,7 +77,6 @@ class EncodedImageCallbackWrapper : public EncodedImageCallback {
class VideoCodingModuleImpl : public VideoCodingModule { class VideoCodingModuleImpl : public VideoCodingModule {
public: public:
VideoCodingModuleImpl(Clock* clock, VideoCodingModuleImpl(Clock* clock,
EventFactory* /* event_factory */,
NackSender* nack_sender, NackSender* nack_sender,
KeyFrameRequestSender* keyframe_request_sender) KeyFrameRequestSender* keyframe_request_sender)
: VideoCodingModule(), : VideoCodingModule(),
@ -219,7 +214,7 @@ class VideoCodingModuleImpl : public VideoCodingModule {
// new jitter buffer is in place. // new jitter buffer is in place.
VideoCodingModule* VideoCodingModule::Create(Clock* clock) { VideoCodingModule* VideoCodingModule::Create(Clock* clock) {
RTC_DCHECK(clock); RTC_DCHECK(clock);
return new VideoCodingModuleImpl(clock, nullptr, nullptr, nullptr); return new VideoCodingModuleImpl(clock, nullptr, nullptr);
} }
} // namespace webrtc } // namespace webrtc