zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Flip histograms to true by default, fix unit in isac_fix_test."

Browse Source 
This reverts commit 7b201012bc7f7cd95249b8314d0d7ebabe966d8b.

Reason for revert: Seems to work, but need to get low bw tests working first

Original change's description:
> Flip histograms to true by default, fix unit in isac_fix_test.
> 
> Requires downstream changes for all WebRTC perf tests, and
> a corresponding recipe change so isac_fix_test starts using the new
> flow.
> 
> Bug: chromium:1029452
> Change-Id: I8918fca9bef003d365037c1c6bf7c55747dfed99
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170633
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#30906}

TBR=phoglund@webrtc.org,mbonadei@webrtc.org

Change-Id: I96c2309cd71be14c5a27b515736a32f1b256453c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1029452
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/171865
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30913}
This commit is contained in:
Patrik Höglund
2020-03-27 07:56:48 +00:00
committed by Commit Bot
parent 0a663bf9f1
commit c59a304901
3 changed files with 11 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
modules/audio_coding/codecs/isac/fix/test/kenny.cc
View File

@ -105,7 +105,7 @@ TEST(IsacFixTest, Kenny) {
FILE *inp, *outp, *f_bn, *outbits;
int endfile;
const char* perf_result_file = NULL;
const char* chartjson_result_file = NULL;
int i;
int errtype, h = 0, k, packetLossPercent = 0;
@ -459,7 +459,7 @@ TEST(IsacFixTest, Kenny) {
printf("Expected --isolated_script_test_perf_output=/some/filename\n");
exit(1);
}
perf_result_file = filename_start + 1;
chartjson_result_file = filename_start + 1;
}
}
@ -858,10 +858,10 @@ TEST(IsacFixTest, Kenny) {
// Record the results with Perf test tools.
webrtc::test::PrintResult("isac", "", "time_per_10ms_frame",
(runtime * 10) / length_file, "ms", false);
(runtime * 10000) / length_file, "us", false);
if (perf_result_file) {
EXPECT_TRUE(webrtc::test::WritePerfResults(perf_result_file));
if (chartjson_result_file) {
EXPECT_TRUE(webrtc::test::WritePerfResults(chartjson_result_file));
}
fclose(inp);