zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix NetworkEmulationManagerTest.ThroughputStats flakiness (again).

Browse Source 
This CL increases tolerance for time measurement variability,
from 1% to 5%. This accounts for heavily loaded bots in CI.

Bug: webrtc:10553
Change-Id: I014f856f9e358f2871a2df8bc39ab0995fdc971f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159284
Reviewed-by: Artem Titov <titovartem@webrtc.org>
Commit-Queue: Yves Gerey <yvesg@google.com>
Cr-Commit-Position: refs/heads/master@{#29765}
This commit is contained in:
Yves Gerey
2019-11-08 20:29:04 +01:00
committed by Commit Bot
parent 229035db8c
commit c65de42f1e
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test/network/network_emulation_unittest.cc
View File

@ -315,7 +315,7 @@ TEST(NetworkEmulationManagerTest, ThroughputStats) {
EXPECT_EQ(st.packets_sent, kNumPacketsSent);
EXPECT_EQ(st.bytes_sent.bytes(), kSinglePacketSize * kNumPacketsSent);
const double tolerance = 0.99; // Accept 1% tolerance for timing.
const double tolerance = 0.95; // Accept 5% tolerance for timing.
EXPECT_GE(st.last_packet_sent_time - st.first_packet_sent_time,
TimeDelta::ms((kNumPacketsSent - 1) * kDelayMs * tolerance));
EXPECT_GT(st.AverageSendRate().bps(), 0);