zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Plot delay feedback in RTCP arrival order.

Browse Source 
This fixes a minor bug in the event_log_visualizer where packets are
processed in RTP send time order rather than RTCP arrival time order.
The bug makes time appear to move backwards if RTCP feedback for a later
RTP packet arrives before the feedback of an earlier RTP packet.

Bug: None
Change-Id: I06e8a25d5c65602bedcfd9e4ea1d23874bee9318
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/156169
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Sebastian Jansson <srte@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29448}
This commit is contained in:
Björn Terelius
2019-10-11 15:06:58 +02:00
committed by Commit Bot
parent 5740f3e2b8
commit c69c1bbda8
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
rtc_tools/rtc_event_log_visualizer/analyzer.cc
View File

@ -18,6 +18,7 @@
#include <string>
#include <utility>
#include "absl/algorithm/container.h"
#include "absl/strings/string_view.h"
#include "api/function_view.h"
#include "api/transport/field_trial_based_config.h"
@ -1455,7 +1456,13 @@ void EventLogAnalyzer::CreateNetworkDelayFeedbackGraph(Plot* plot) {
int64_t min_rtt_ms = std::numeric_limits<int64_t>::max();
int64_t prev_y = 0;
for (auto packet : GetNetworkTrace(parsed_log_)) {
std::vector<MatchedSendArrivalTimes> matched_rtp_rtcp =
GetNetworkTrace(parsed_log_);
absl::c_stable_sort(matched_rtp_rtcp, [](const MatchedSendArrivalTimes& a,
const MatchedSendArrivalTimes& b) {
return a.feedback_arrival_time_ms < b.feedback_arrival_time_ms;
});
for (const auto& packet : matched_rtp_rtcp) {
if (packet.arrival_time_ms == PacketFeedback::kNotReceived)
continue;
float x = config_.GetCallTimeSec(1000 * packet.feedback_arrival_time_ms);