zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*""

Browse Source 
This reverts commit 588c548657b3ddf76e7b3f241263eef7f5799f16.

Reason for revert: 

Breaks Chrome FYI:

/b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check
  -> returned 1
ERROR at //build/split_static_library.gni:12:5: Dependency not allowed.
    static_library(target_name) {
    ^----------------------------
The item //content/renderer:renderer
can not depend on //third_party/webrtc/media:rtc_internal_video_codecs
because it is not in //third_party/webrtc/media:rtc_internal_video_codecs's visibility list: [
  //third_party/webrtc/*
  //third_party/webrtc_overrides/*
]

 https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webrtc.fyi%2FLinux_Builder%2F23560%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout

Original change's description:
> GN rtc_* templates: Set default visibility to webrtc_root + "/*"
> 
> This means that by default, targets are visible to everything under
> the WebRTC root, but not visible to anything else.
> 
> API targets are manually tagged with visibility "*", so that targets
> outside the WebRTC tree can see them.
> 
> BUG=webrtc:8254
> 
> Change-Id: Icdbee6e0d22d93240ff2fb530c8f9dc48e351509
> Reviewed-on: https://webrtc-review.googlesource.com/24140
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#21548}

TBR=mbonadei@webrtc.org,kwiberg@webrtc.org

Change-Id: I06620ce3d6f67482935c22efa231dd6cab91625a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:8254
Reviewed-on: https://webrtc-review.googlesource.com/38760
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21555}
This commit is contained in:
Per Kjellander
2018-01-10 15:14:40 +00:00
committed by Commit Bot
parent 55d1809d0d
commit c73e1f4378
42 changed files with 22 additions and 167 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
modules/video_coding/BUILD.gn
View File

@ -9,7 +9,6 @@
import("../../webrtc.gni")
rtc_static_library("video_coding") {
visibility = [ "*" ]
sources = [
"codec_database.cc",
"codec_database.h",
@ -169,7 +168,6 @@ rtc_source_set("codec_globals_headers") {
}
rtc_source_set("video_coding_utility") {
visibility = [ "*" ]
sources = [
"codecs/interface/video_codec_interface.h",
"codecs/interface/video_error_codes.h",
@ -214,7 +212,6 @@ rtc_source_set("video_coding_utility") {
}
rtc_static_library("webrtc_h264") {
visibility = [ "*" ]
sources = [
"codecs/h264/h264.cc",
"codecs/h264/include/h264.h",
@ -258,7 +255,6 @@ rtc_static_library("webrtc_h264") {
}
rtc_static_library("webrtc_i420") {
visibility = [ "*" ]
sources = [
"codecs/i420/i420.cc",
"codecs/i420/include/i420.h",
@ -336,7 +332,6 @@ rtc_source_set("webrtc_vp8_helpers") {
# This target includes the internal SW codec.
rtc_static_library("webrtc_vp8") {
visibility = [ "*" ]
sources = [
"codecs/vp8/default_temporal_layers.cc",
"codecs/vp8/default_temporal_layers.h",
@ -381,7 +376,6 @@ rtc_static_library("webrtc_vp8") {
}
rtc_static_library("webrtc_vp9") {
visibility = [ "*" ]
if (rtc_libvpx_build_vp9) {
sources = [
"codecs/vp9/include/vp9.h",