zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "GN rtc_* templates: Set default visibility to webrtc_root + "/*""

Browse Source 
This reverts commit 588c548657b3ddf76e7b3f241263eef7f5799f16.

Reason for revert: 

Breaks Chrome FYI:

/b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check
  -> returned 1
ERROR at //build/split_static_library.gni:12:5: Dependency not allowed.
    static_library(target_name) {
    ^----------------------------
The item //content/renderer:renderer
can not depend on //third_party/webrtc/media:rtc_internal_video_codecs
because it is not in //third_party/webrtc/media:rtc_internal_video_codecs's visibility list: [
  //third_party/webrtc/*
  //third_party/webrtc_overrides/*
]

 https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webrtc.fyi%2FLinux_Builder%2F23560%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout

Original change's description:
> GN rtc_* templates: Set default visibility to webrtc_root + "/*"
> 
> This means that by default, targets are visible to everything under
> the WebRTC root, but not visible to anything else.
> 
> API targets are manually tagged with visibility "*", so that targets
> outside the WebRTC tree can see them.
> 
> BUG=webrtc:8254
> 
> Change-Id: Icdbee6e0d22d93240ff2fb530c8f9dc48e351509
> Reviewed-on: https://webrtc-review.googlesource.com/24140
> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
> Commit-Queue: Karl Wiberg <kwiberg@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#21548}

TBR=mbonadei@webrtc.org,kwiberg@webrtc.org

Change-Id: I06620ce3d6f67482935c22efa231dd6cab91625a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:8254
Reviewed-on: https://webrtc-review.googlesource.com/38760
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21555}
This commit is contained in:
Per Kjellander
2018-01-10 15:14:40 +00:00
committed by Commit Bot
parent 55d1809d0d
commit c73e1f4378
42 changed files with 22 additions and 167 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
api/BUILD.gn
View File

@ -13,14 +13,12 @@ if (is_android) {
}
group("api") {
visibility = [ "*" ]
public_deps = [
":libjingle_peerconnection_api",
]
}
rtc_source_set("call_api") {
visibility = [ "*" ]
sources = [
"call/audio_sink.h",
]
@ -36,7 +34,6 @@ rtc_source_set("call_api") {
}
rtc_static_library("libjingle_peerconnection_api") {
visibility = [ "*" ]
cflags = []
sources = [
"candidate.cc",
@ -117,8 +114,6 @@ rtc_static_library("libjingle_peerconnection_api") {
}
rtc_source_set("peerconnection_and_implicit_call_api") {
visibility = [ "*" ]
# The peerconnectioninterface.h file pulls in call/callfactoryinterface.h
# and the entire call module with it. We need to either get rid of this
# dependency or pull most of call/ into the API. For now, silence the warnings
@ -131,14 +126,12 @@ rtc_source_set("peerconnection_and_implicit_call_api") {
}
rtc_source_set("libjingle_logging_api") {
visibility = [ "*" ]
sources = [
"rtceventlogoutput.h",
]
}
rtc_source_set("ortc_api") {
visibility = [ "*" ]
sources = [
"ortc/mediadescription.cc",
"ortc/mediadescription.h",
@ -171,7 +164,6 @@ rtc_source_set("ortc_api") {
}
rtc_source_set("rtc_stats_api") {
visibility = [ "*" ]
cflags = []
sources = [
"stats/rtcstats.h",
@ -187,7 +179,6 @@ rtc_source_set("rtc_stats_api") {
}
rtc_source_set("audio_mixer_api") {
visibility = [ "*" ]
sources = [
"audio/audio_mixer.h",
]
@ -199,14 +190,12 @@ rtc_source_set("audio_mixer_api") {
}
rtc_source_set("transport_api") {
visibility = [ "*" ]
sources = [
"call/transport.h",
]
}
rtc_source_set("video_frame_api") {
visibility = [ "*" ]
sources = [
"video/video_content_type.cc",
"video/video_content_type.h",
@ -226,7 +215,6 @@ rtc_source_set("video_frame_api") {
}
rtc_source_set("video_frame_api_i420") {
visibility = [ "*" ]
sources = [
"video/i420_buffer.cc",
"video/i420_buffer.h",
@ -241,7 +229,6 @@ rtc_source_set("video_frame_api_i420") {
}
rtc_source_set("array_view") {
visibility = [ "*" ]
sources = [
"array_view.h",
]
@ -252,7 +239,6 @@ rtc_source_set("array_view") {
}
rtc_source_set("optional") {
visibility = [ "*" ]
sources = [
"optional.cc",
"optional.h",
@ -265,7 +251,6 @@ rtc_source_set("optional") {
}
rtc_source_set("refcountedbase") {
visibility = [ "*" ]
sources = [
"refcountedbase.h",
]
@ -275,7 +260,6 @@ rtc_source_set("refcountedbase") {
}
rtc_source_set("libjingle_peerconnection_test_api") {
visibility = [ "*" ]
testonly = true
sources = [
"test/fakeconstraints.h",

3
api/audio_codecs/BUILD.gn
View File

@ -13,7 +13,6 @@ if (is_android) {
}
rtc_source_set("audio_codecs_api") {
visibility = [ "*" ]
sources = [
"audio_decoder.cc",
"audio_decoder.h",
@ -39,7 +38,6 @@ rtc_source_set("audio_codecs_api") {
}
rtc_static_library("builtin_audio_decoder_factory") {
visibility = [ "*" ]
sources = [
"builtin_audio_decoder_factory.cc",
"builtin_audio_decoder_factory.h",
@ -68,7 +66,6 @@ rtc_static_library("builtin_audio_decoder_factory") {
}
rtc_static_library("builtin_audio_encoder_factory") {
visibility = [ "*" ]
sources = [
"builtin_audio_encoder_factory.cc",
"builtin_audio_encoder_factory.h",

2
api/audio_codecs/L16/BUILD.gn
View File

@ -13,7 +13,6 @@ if (is_android) {
}
rtc_static_library("audio_encoder_L16") {
visibility = [ "*" ]
sources = [
"audio_encoder_L16.cc",
"audio_encoder_L16.h",
@ -28,7 +27,6 @@ rtc_static_library("audio_encoder_L16") {
}
rtc_static_library("audio_decoder_L16") {
visibility = [ "*" ]
sources = [
"audio_decoder_L16.cc",
"audio_decoder_L16.h",

2
api/audio_codecs/g711/BUILD.gn
View File

@ -13,7 +13,6 @@ if (is_android) {
}
rtc_static_library("audio_encoder_g711") {
visibility = [ "*" ]
sources = [
"audio_encoder_g711.cc",
"audio_encoder_g711.h",
@ -28,7 +27,6 @@ rtc_static_library("audio_encoder_g711") {
}
rtc_static_library("audio_decoder_g711") {
visibility = [ "*" ]
sources = [
"audio_decoder_g711.cc",
"audio_decoder_g711.h",

3
api/audio_codecs/g722/BUILD.gn
View File

@ -13,14 +13,12 @@ if (is_android) {
}
rtc_source_set("audio_encoder_g722_config") {
visibility = [ "*" ]
sources = [
"audio_encoder_g722_config.h",
]
}
rtc_static_library("audio_encoder_g722") {
visibility = [ "*" ]
sources = [
"audio_encoder_g722.cc",
"audio_encoder_g722.h",
@ -36,7 +34,6 @@ rtc_static_library("audio_encoder_g722") {
}
rtc_static_library("audio_decoder_g722") {
visibility = [ "*" ]
sources = [
"audio_decoder_g722.cc",
"audio_decoder_g722.h",

3
api/audio_codecs/ilbc/BUILD.gn
View File

@ -13,14 +13,12 @@ if (is_android) {
}
rtc_source_set("audio_encoder_ilbc_config") {
visibility = [ "*" ]
sources = [
"audio_encoder_ilbc_config.h",
]
}
rtc_static_library("audio_encoder_ilbc") {
visibility = [ "*" ]
sources = [
"audio_encoder_ilbc.cc",
"audio_encoder_ilbc.h",
@ -36,7 +34,6 @@ rtc_static_library("audio_encoder_ilbc") {
}
rtc_static_library("audio_decoder_ilbc") {
visibility = [ "*" ]
sources = [
"audio_decoder_ilbc.cc",
"audio_decoder_ilbc.h",

6
api/audio_codecs/isac/BUILD.gn
View File

@ -18,7 +18,6 @@ if (is_android) {
# on cleverly chosen criteria.
rtc_source_set("audio_encoder_isac") {
visibility = [ "*" ]
public = [
"audio_encoder_isac.h",
]
@ -35,7 +34,6 @@ rtc_source_set("audio_encoder_isac") {
}
rtc_source_set("audio_decoder_isac") {
visibility = [ "*" ]
public = [
"audio_decoder_isac.h",
]
@ -67,7 +65,6 @@ config("isac_config") {
}
rtc_static_library("audio_encoder_isac_fix") {
visibility = [ "*" ]
sources = [
"audio_encoder_isac_fix.cc",
"audio_encoder_isac_fix.h",
@ -82,7 +79,6 @@ rtc_static_library("audio_encoder_isac_fix") {
}
rtc_static_library("audio_decoder_isac_fix") {
visibility = [ "*" ]
sources = [
"audio_decoder_isac_fix.cc",
"audio_decoder_isac_fix.h",
@ -97,7 +93,6 @@ rtc_static_library("audio_decoder_isac_fix") {
}
rtc_static_library("audio_encoder_isac_float") {
visibility = [ "*" ]
sources = [
"audio_encoder_isac_float.cc",
"audio_encoder_isac_float.h",
@ -112,7 +107,6 @@ rtc_static_library("audio_encoder_isac_float") {
}
rtc_static_library("audio_decoder_isac_float") {
visibility = [ "*" ]
sources = [
"audio_decoder_isac_float.cc",
"audio_decoder_isac_float.h",

3
api/audio_codecs/opus/BUILD.gn
View File

@ -13,7 +13,6 @@ if (is_android) {
}
rtc_static_library("audio_encoder_opus_config") {
visibility = [ "*" ]
sources = [
"audio_encoder_opus_config.cc",
"audio_encoder_opus_config.h",
@ -31,7 +30,6 @@ rtc_static_library("audio_encoder_opus_config") {
}
rtc_source_set("audio_encoder_opus") {
visibility = [ "*" ]
public = [
"audio_encoder_opus.h",
]
@ -52,7 +50,6 @@ rtc_source_set("audio_encoder_opus") {
}
rtc_static_library("audio_decoder_opus") {
visibility = [ "*" ]
sources = [
"audio_decoder_opus.cc",
"audio_decoder_opus.h",

1
api/video_codecs/BUILD.gn
View File

@ -13,7 +13,6 @@ if (is_android) {
}
rtc_source_set("video_codecs_api") {
visibility = [ "*" ]
sources = [
"sdp_video_format.h",
"video_decoder.h",

1
audio/utility/BUILD.gn
View File

@ -14,7 +14,6 @@ group("utility") {
}
rtc_static_library("audio_frame_operations") {
visibility = [ "*" ]
sources = [
"audio_frame_operations.cc",
"audio_frame_operations.h",

1
call/BUILD.gn
View File

@ -54,7 +54,6 @@ rtc_source_set("rtp_interfaces") {
}
rtc_source_set("rtp_receiver") {
visibility = [ "*" ]
sources = [
"rtcp_demuxer.cc",
"rtcp_demuxer.h",

8
common_audio/BUILD.gn
View File

@ -107,7 +107,7 @@ rtc_static_library("common_audio") {
}
rtc_source_set("mock_common_audio") {
visibility += webrtc_default_visibility
visibility += [ "*" ]
testonly = true
sources = [
"mocks/mock_smoothing_filter.h",
@ -263,14 +263,14 @@ rtc_source_set("sinc_resampler") {
}
rtc_source_set("fir_filter") {
visibility += webrtc_default_visibility
visibility += [ "*" ]
sources = [
"fir_filter.h",
]
}
rtc_source_set("fir_filter_factory") {
visibility += webrtc_default_visibility
visibility += [ "*" ]
sources = [
"fir_filter_c.cc",
"fir_filter_c.h",
@ -398,7 +398,7 @@ if (rtc_build_with_neon) {
if (rtc_include_tests) {
rtc_test("common_audio_unittests") {
visibility += webrtc_default_visibility
visibility += [ "*" ]
testonly = true
sources = [

2
common_video/BUILD.gn
View File

@ -13,8 +13,6 @@ config("common_video_config") {
}
rtc_static_library("common_video") {
visibility = [ "*" ]
sources = [
"bitrate_adjuster.cc",
"h264/h264_bitstream_parser.cc",

1
logging/BUILD.gn
View File

@ -88,7 +88,6 @@ rtc_source_set("rtc_event_log_api") {
}
rtc_static_library("rtc_event_log_impl") {
visibility = [ "*" ]
sources = [
"rtc_event_log/encoder/rtc_event_log_encoder.h",
"rtc_event_log/encoder/rtc_event_log_encoder_legacy.cc",

4
media/BUILD.gn
View File

@ -33,7 +33,6 @@ config("rtc_media_warnings_config") {
}
rtc_source_set("rtc_h264_profile_id") {
visibility = [ "*" ]
sources = [
"base/h264_profile_level_id.cc",
"base/h264_profile_level_id.h",
@ -53,7 +52,6 @@ rtc_source_set("rtc_h264_profile_id") {
}
rtc_static_library("rtc_media_base") {
visibility = [ "*" ]
defines = []
libs = []
deps = [
@ -215,7 +213,6 @@ rtc_static_library("rtc_internal_video_codecs") {
}
rtc_static_library("rtc_audio_video") {
visibility = [ "*" ]
defines = []
libs = []
deps = [
@ -376,7 +373,6 @@ rtc_static_library("rtc_data") {
}
rtc_source_set("rtc_media") {
visibility = [ "*" ]
public_deps = [
":rtc_audio_video",
":rtc_data",

1
modules/BUILD.gn
View File

@ -43,7 +43,6 @@ rtc_source_set("module_api_public") {
}
rtc_source_set("module_api") {
visibility = [ "*" ]
sources = [
"include/module.h",
"include/module_common_types.h",

32
modules/audio_coding/BUILD.gn
View File

@ -40,7 +40,7 @@ audio_coding_deps = audio_codec_deps + [
]
rtc_static_library("audio_format_conversion") {
visibility += webrtc_default_visibility
visibility += [ "*" ]
sources = [
"codecs/audio_format_conversion.cc",
"codecs/audio_format_conversion.h",
@ -57,7 +57,7 @@ rtc_static_library("audio_format_conversion") {
}
rtc_static_library("rent_a_codec") {
visibility += webrtc_default_visibility
visibility += [ "*" ]
sources = [
"acm2/acm_codec_database.cc",
"acm2/acm_codec_database.h",
@ -297,7 +297,7 @@ config("ilbc_config") {
}
rtc_static_library("ilbc") {
visibility += webrtc_default_visibility
visibility += [ "*" ]
sources = [
"codecs/ilbc/audio_decoder_ilbc.cc",
"codecs/ilbc/audio_decoder_ilbc.h",
@ -823,7 +823,7 @@ rtc_source_set("pcm16b_c") {
}
rtc_static_library("webrtc_opus") {
visibility += webrtc_default_visibility
visibility += [ "*" ]
sources = [
"codecs/opus/audio_decoder_opus.cc",
"codecs/opus/audio_decoder_opus.h",
@ -884,7 +884,7 @@ rtc_source_set("webrtc_opus_c") {
if (rtc_enable_protobuf) {
proto_library("ana_debug_dump_proto") {
visibility += webrtc_default_visibility
visibility += [ "*" ]
sources = [
"audio_network_adaptor/debug_dump.proto",
]
@ -902,7 +902,7 @@ if (rtc_enable_protobuf) {
}
rtc_static_library("audio_network_adaptor_config") {
visibility += webrtc_default_visibility
visibility += [ "*" ]
sources = [
"audio_network_adaptor/audio_network_adaptor_config.cc",
"audio_network_adaptor/include/audio_network_adaptor_config.h",
@ -913,7 +913,7 @@ rtc_static_library("audio_network_adaptor_config") {
}
rtc_static_library("audio_network_adaptor") {
visibility += webrtc_default_visibility
visibility += [ "*" ]
sources = [
"audio_network_adaptor/audio_network_adaptor_impl.cc",
"audio_network_adaptor/audio_network_adaptor_impl.h",
@ -984,7 +984,7 @@ rtc_source_set("neteq_decoder_enum") {
}
rtc_static_library("neteq") {
visibility += webrtc_default_visibility
visibility += [ "*" ]
sources = [
"neteq/accelerate.cc",
"neteq/accelerate.h",
@ -1082,7 +1082,7 @@ rtc_static_library("neteq") {
# that ultimately are built and run as a part of the Chromium ecosystem, which
# does not set the rtc_include_tests flag.
rtc_source_set("neteq_tools_minimal") {
visibility += webrtc_default_visibility
visibility += [ "*" ]
sources = [
"neteq/tools/audio_sink.cc",
"neteq/tools/audio_sink.h",
@ -1119,7 +1119,7 @@ rtc_source_set("neteq_tools_minimal") {
}
rtc_source_set("neteq_test_tools") {
visibility += webrtc_default_visibility
visibility += [ "*" ]
testonly = true
sources = [
"neteq/tools/audio_checksum.h",
@ -1178,7 +1178,7 @@ config("neteq_tools_config") {
}
rtc_source_set("neteq_tools") {
visibility += webrtc_default_visibility
visibility += [ "*" ]
sources = [
"neteq/tools/fake_decode_from_file.cc",
"neteq/tools/fake_decode_from_file.h",
@ -1214,7 +1214,7 @@ rtc_source_set("neteq_tools") {
}
rtc_source_set("neteq_input_audio_tools") {
visibility += webrtc_default_visibility
visibility += [ "*" ]
sources = [
"neteq/tools/input_audio_file.cc",
"neteq/tools/input_audio_file.h",
@ -1275,7 +1275,7 @@ if (rtc_include_tests) {
}
group("audio_coding_tests") {
visibility += webrtc_default_visibility
visibility += [ "*" ]
testonly = true
public_deps = [
":acm_receive_test",
@ -1310,7 +1310,7 @@ if (rtc_include_tests) {
rtc_source_set("audio_coding_modules_tests") {
testonly = true
visibility += webrtc_default_visibility
visibility += [ "*" ]
sources = [
"test/ACMTest.h",
@ -1374,7 +1374,7 @@ if (rtc_include_tests) {
rtc_source_set("audio_coding_perf_tests") {
testonly = true
visibility += webrtc_default_visibility
visibility += [ "*" ]
sources = [
"codecs/opus/opus_complexity_unittest.cc",
@ -2053,7 +2053,7 @@ if (rtc_include_tests) {
rtc_source_set("audio_coding_unittests") {
testonly = true
visibility += webrtc_default_visibility
visibility += [ "*" ]
sources = [
"acm2/acm_receiver_unittest.cc",

1
modules/audio_device/BUILD.gn
View File

@ -46,7 +46,6 @@ config("audio_device_warnings_config") {
}
rtc_source_set("audio_device") {
visibility = [ "*" ]
public_deps = [
":audio_device_generic",
]

3
modules/audio_processing/BUILD.gn
View File

@ -26,7 +26,6 @@ config("apm_debug_dump") {
}
rtc_static_library("audio_processing") {
visibility = [ "*" ]
configs += [ ":apm_debug_dump" ]
sources = [
"aec/aec_resampler.cc",
@ -291,7 +290,6 @@ rtc_static_library("audio_processing") {
}
rtc_source_set("audio_processing_statistics") {
visibility = [ "*" ]
sources = [
"include/audio_processing_statistics.cc",
"include/audio_processing_statistics.h",
@ -783,7 +781,6 @@ if (rtc_include_tests) {
}
rtc_source_set("audioproc_test_utils") {
visibility = [ "*" ]
testonly = true
sources = [
"test/audio_buffer_tools.cc",

1
modules/audio_processing/aec_dump/BUILD.gn
View File

@ -9,7 +9,6 @@
import("../../../webrtc.gni") # This contains def of 'rtc_enable_protobuf'
rtc_source_set("aec_dump") {
visibility = [ "*" ]
sources = [
"aec_dump_factory.h",
]

1
modules/bitrate_controller/BUILD.gn
View File

@ -9,7 +9,6 @@
import("../../webrtc.gni")
rtc_static_library("bitrate_controller") {
visibility = [ "*" ]
sources = [
"bitrate_controller_impl.cc",
"bitrate_controller_impl.h",

1
modules/congestion_controller/BUILD.gn
View File

@ -17,7 +17,6 @@ config("bwe_test_logging") {
}
rtc_static_library("congestion_controller") {
visibility = [ "*" ]
configs += [ ":bwe_test_logging" ]
sources = [
"include/receive_side_congestion_controller.h",

2
modules/desktop_capture/BUILD.gn
View File

@ -12,7 +12,6 @@ import("../../webrtc.gni")
use_desktop_capture_differ_sse2 = current_cpu == "x86" || current_cpu == "x64"
rtc_static_library("primitives") {
visibility = [ "*" ]
sources = [
"desktop_capture_types.h",
"desktop_frame.cc",
@ -160,7 +159,6 @@ if (rtc_include_tests) {
}
rtc_source_set("desktop_capture") {
visibility = [ "*" ]
public_deps = [
":desktop_capture_generic",
]

1
modules/media_file/BUILD.gn
View File

@ -13,7 +13,6 @@ config("media_file_config") {
}
rtc_static_library("media_file") {
visibility = [ "*" ]
sources = [
"media_file.h",
"media_file_defines.h",

1
modules/remote_bitrate_estimator/BUILD.gn
View File

@ -9,7 +9,6 @@
import("../../webrtc.gni")
rtc_static_library("remote_bitrate_estimator") {
visibility = [ "*" ]
sources = [
"aimd_rate_control.cc",
"aimd_rate_control.h",

2
modules/rtp_rtcp/BUILD.gn
View File

@ -97,7 +97,6 @@ rtc_source_set("rtp_rtcp_format") {
}
rtc_static_library("rtp_rtcp") {
visibility = [ "*" ]
sources = [
"include/flexfec_receiver.h",
"include/flexfec_sender.h",
@ -231,7 +230,6 @@ rtc_static_library("rtp_rtcp") {
}
rtc_source_set("rtcp_transceiver") {
visibility = [ "*" ]
public = [
"source/rtcp_transceiver.h",
"source/rtcp_transceiver_config.h",

2
modules/utility/BUILD.gn
View File

@ -9,7 +9,6 @@
import("../../webrtc.gni")
rtc_static_library("utility") {
visibility = [ "*" ]
sources = [
"include/audio_frame_operations.h",
"include/helpers_android.h",
@ -46,7 +45,6 @@ rtc_static_library("utility") {
rtc_source_set("mock_process_thread") {
testonly = true
visibility = [ "*" ]
sources = [
"include/mock/mock_process_thread.h",
]

1
modules/video_capture/BUILD.gn
View File

@ -47,7 +47,6 @@ rtc_static_library("video_capture_module") {
}
rtc_static_library("video_capture") {
visibility = [ "*" ]
sources = [
"external/device_info_external.cc",
"external/video_capture_external.cc",

6
modules/video_coding/BUILD.gn
View File

@ -9,7 +9,6 @@
import("../../webrtc.gni")
rtc_static_library("video_coding") {
visibility = [ "*" ]
sources = [
"codec_database.cc",
"codec_database.h",
@ -169,7 +168,6 @@ rtc_source_set("codec_globals_headers") {
}
rtc_source_set("video_coding_utility") {
visibility = [ "*" ]
sources = [
"codecs/interface/video_codec_interface.h",
"codecs/interface/video_error_codes.h",
@ -214,7 +212,6 @@ rtc_source_set("video_coding_utility") {
}
rtc_static_library("webrtc_h264") {
visibility = [ "*" ]
sources = [
"codecs/h264/h264.cc",
"codecs/h264/include/h264.h",
@ -258,7 +255,6 @@ rtc_static_library("webrtc_h264") {
}
rtc_static_library("webrtc_i420") {
visibility = [ "*" ]
sources = [
"codecs/i420/i420.cc",
"codecs/i420/include/i420.h",
@ -336,7 +332,6 @@ rtc_source_set("webrtc_vp8_helpers") {
# This target includes the internal SW codec.
rtc_static_library("webrtc_vp8") {
visibility = [ "*" ]
sources = [
"codecs/vp8/default_temporal_layers.cc",
"codecs/vp8/default_temporal_layers.h",
@ -381,7 +376,6 @@ rtc_static_library("webrtc_vp8") {
}
rtc_static_library("webrtc_vp9") {
visibility = [ "*" ]
if (rtc_libvpx_build_vp9) {
sources = [
"codecs/vp9/include/vp9.h",

1
modules/video_processing/BUILD.gn
View File

@ -12,7 +12,6 @@ import("../../webrtc.gni")
build_video_processing_sse2 = current_cpu == "x86" || current_cpu == "x64"
rtc_static_library("video_processing") {
visibility = [ "*" ]
sources = [
"util/denoiser_filter.cc",
"util/denoiser_filter_c.cc",

2
p2p/BUILD.gn
View File

@ -20,7 +20,6 @@ config("rtc_p2p_inherited_config") {
}
rtc_static_library("rtc_p2p") {
visibility = [ "*" ]
sources = [
"base/asyncstuntcpsocket.cc",
"base/asyncstuntcpsocket.h",
@ -195,7 +194,6 @@ if (rtc_include_tests) {
}
rtc_static_library("libstunprober") {
visibility = [ "*" ]
sources = [
"stunprober/stunprober.cc",
"stunprober/stunprober.h",

4
pc/BUILD.gn
View File

@ -26,7 +26,6 @@ config("rtc_pc_config") {
}
rtc_static_library("rtc_pc_base") {
visibility = [ "*" ]
defines = []
sources = [
"audiomonitor.cc",
@ -100,7 +99,6 @@ rtc_static_library("rtc_pc_base") {
}
rtc_source_set("rtc_pc") {
visibility = [ "*" ]
deps = [
":rtc_pc_base",
"../media:rtc_audio_video",
@ -117,7 +115,6 @@ config("libjingle_peerconnection_warnings_config") {
}
rtc_static_library("peerconnection") {
visibility = [ "*" ]
cflags = []
sources = [
"audiotrack.cc",
@ -240,7 +237,6 @@ rtc_static_library("create_pc_factory") {
}
rtc_source_set("libjingle_peerconnection") {
visibility = [ "*" ]
deps = [
":create_pc_factory",
":peerconnection",

7
rtc_base/BUILD.gn
View File

@ -64,7 +64,6 @@ if (!rtc_build_ssl) {
}
source_set("protobuf_utils") {
visibility = [ "*" ]
sources = [
"protobuf_utils.h",
]
@ -82,7 +81,6 @@ source_set("compile_assert_c") {
}
rtc_source_set("rtc_base_approved") {
visibility = [ "*" ]
public_deps = [
":rtc_base_approved_generic",
]
@ -379,7 +377,6 @@ if (is_mac && !build_with_chromium) {
}
rtc_source_set("rtc_task_queue") {
visibility = [ "*" ]
deps = [
":rtc_base_approved",
]
@ -408,7 +405,6 @@ rtc_source_set("rtc_task_queue_api") {
}
rtc_source_set("rtc_task_queue_impl") {
visibility = [ "*" ]
deps = [
":checks",
":rtc_base_approved",
@ -510,7 +506,6 @@ rtc_source_set("rtc_json") {
}
rtc_static_library("rtc_base") {
visibility = [ "*" ]
public_deps = [
":rtc_base_generic",
]
@ -794,7 +789,6 @@ rtc_static_library("rtc_base_generic") {
}
rtc_source_set("gtest_prod") {
visibility = [ "*" ]
sources = [
"gtest_prod_util.h",
]
@ -990,7 +984,6 @@ if (rtc_include_tests) {
}
rtc_source_set("rtc_task_queue_unittests") {
visibility = [ "*" ]
testonly = true
sources = [

2
rtc_tools/BUILD.gn
View File

@ -71,7 +71,6 @@ rtc_static_library("video_quality_analysis") {
}
rtc_executable("frame_analyzer") {
visibility = [ "*" ]
sources = [
"frame_analyzer/frame_analyzer.cc",
]
@ -122,7 +121,6 @@ if (!build_with_chromium) {
}
rtc_executable("rgba_to_i420_converter") {
visibility = [ "*" ]
sources = [
"converter/converter.cc",
"converter/converter.h",

3
sdk/BUILD.gn
View File

@ -212,7 +212,6 @@ if (is_ios || is_mac) {
}
rtc_static_library("ui_objc") {
visibility = [ "*" ]
if (is_ios) {
sources = [
"objc/Framework/Classes/UI/RTCCameraPreviewView.m",
@ -274,7 +273,6 @@ if (is_ios || is_mac) {
}
rtc_static_library("peerconnection_objc") {
visibility = [ "*" ]
sources = [
"objc/Framework/Classes/PeerConnection/RTCAVFoundationVideoSource+Private.h",
"objc/Framework/Classes/PeerConnection/RTCAVFoundationVideoSource.mm",
@ -372,7 +370,6 @@ if (is_ios || is_mac) {
# The applications which only use WebRTC DataChannel can depend on this
# target instead of rtc_sdk_objc.
rtc_static_library("peerconnectionfactory_no_media_objc") {
visibility = [ "*" ]
defines = [ "HAVE_NO_MEDIA" ]
sources = [

3
sdk/android/BUILD.gn
View File

@ -63,7 +63,6 @@ generate_jar_jni("generated_external_classes_jni") {
}
rtc_source_set("base_jni") {
visibility = [ "*" ]
sources = [
"src/jni/androidhistogram.cc",
"src/jni/class_loader.cc",
@ -442,7 +441,6 @@ rtc_static_library("peerconnection_jni") {
}
rtc_static_library("libjingle_peerconnection_jni") {
visibility = [ "*" ]
public_deps = [
":audio_jni",
":base_jni",
@ -462,7 +460,6 @@ generate_jni("generated_metrics_jni") {
}
rtc_static_library("libjingle_peerconnection_metrics_default_jni") {
visibility = [ "*" ]
sources = [
"src/jni/androidmetrics.cc",
]

2
stats/BUILD.gn
View File

@ -15,7 +15,6 @@ group("stats") {
}
rtc_static_library("rtc_stats") {
visibility = [ "*" ]
cflags = []
sources = [
"rtcstats.cc",
@ -30,7 +29,6 @@ rtc_static_library("rtc_stats") {
}
rtc_source_set("rtc_stats_test_utils") {
visibility = [ "*" ]
cflags = []
sources = [
"test/rtcteststats.cc",

19
style-guide.md
View File

@ -116,7 +116,7 @@ Chromium style guide.
[gn]: https://chromium.googlesource.com/chromium/src/tools/gn/
[chr-gn-style]: https://chromium.googlesource.com/chromium/src/tools/gn/+/HEAD/docs/style_guide.md
### <a name="webrtc-gn-templates"></a>WebRTC-specific GN templates
### WebRTC-specific GN templates
Use the following [GN templates][gn-templ] to ensure that all
our [targets][gn-target] are built with the same configuration:
@ -132,23 +132,6 @@ instead of | use
[gn-templ]: https://chromium.googlesource.com/chromium/src/tools/gn/+/HEAD/docs/language.md#Templates
[gn-target]: https://chromium.googlesource.com/chromium/src/tools/gn/+/HEAD/docs/language.md#Targets
### Target visibility and the native API
The [WebRTC-specific GN templates](#webrtc-gn-templates) declare build
targets whose default `visibility` allows all other targets in the
WebRTC tree (and no targets outside the tree) to depend on them.
Prefer to restrict the visibility if possible:
* If a target is used by only one or a tiny number of other targets,
prefer to list them explicitly: `visibility = [ ":foo", ":bar" ]`
* If a target is used only by targets in the same `BUILD.gn` file:
`visibility = [ ":*" ]`.
Setting `visibility = [ "*" ]` means that targets outside the WebRTC
tree can depend on this target; use this only for build targets whose
headers are part of the [native API](native-api.md).
### Conditional compilation with the C preprocessor
Avoid using the C preprocessor to conditionally enable or disable

4
system_wrappers/BUILD.gn
View File

@ -13,7 +13,6 @@ if (is_android) {
import("../webrtc.gni")
rtc_static_library("system_wrappers") {
visibility = [ "*" ]
sources = [
"include/aligned_array.h",
"include/aligned_malloc.h",
@ -131,7 +130,6 @@ rtc_source_set("field_trial_api") {
}
rtc_source_set("metrics_api") {
visibility = [ "*" ]
sources = [
"include/metrics.h",
]
@ -143,7 +141,6 @@ rtc_source_set("metrics_api") {
}
rtc_source_set("field_trial_default") {
visibility = [ "*" ]
sources = [
"include/field_trial_default.h",
"source/field_trial_default.cc",
@ -154,7 +151,6 @@ rtc_source_set("field_trial_default") {
}
rtc_source_set("metrics_default") {
visibility = [ "*" ]
sources = [
"include/metrics_default.h",
"source/metrics_default.cc",

7
test/BUILD.gn
View File

@ -36,7 +36,6 @@ group("test") {
}
rtc_source_set("video_test_common") {
visibility = [ "*" ]
testonly = true
sources = [
"fake_texture_frame.cc",
@ -106,7 +105,6 @@ rtc_source_set("rtp_test_utils") {
}
rtc_source_set("field_trial") {
visibility = [ "*" ]
testonly = true
sources = [
"field_trial.cc",
@ -121,7 +119,6 @@ rtc_source_set("field_trial") {
}
rtc_source_set("perf_test") {
visibility = [ "*" ]
testonly = true
sources = [
"testsupport/perf_test.cc",
@ -150,7 +147,6 @@ if (is_ios) {
}
rtc_source_set("test_support") {
visibility = [ "*" ]
testonly = true
sources = [
@ -200,7 +196,6 @@ rtc_source_set("test_support") {
if (rtc_include_tests) {
rtc_source_set("test_main") {
visibility = [ "*" ]
testonly = true
sources = [
"test_main.cc",
@ -483,7 +478,6 @@ rtc_source_set("fileutils_unittests") {
}
rtc_source_set("direct_transport") {
visibility = [ "*" ]
testonly = true
sources = [
"direct_transport.cc",
@ -524,7 +518,6 @@ rtc_source_set("single_threaded_task_queue") {
}
rtc_source_set("fake_audio_device") {
visibility = [ "*" ]
testonly = true
sources = [
"fake_audio_device.cc",

2
voice_engine/BUILD.gn
View File

@ -104,7 +104,7 @@ rtc_static_library("audio_level") {
if (rtc_include_tests) {
rtc_test("voice_engine_unittests") {
visibility += webrtc_default_visibility
visibility += [ "*" ]
deps = [
":voice_engine",
"../api/audio_codecs:builtin_audio_decoder_factory",

22
webrtc.gni
View File

@ -264,13 +264,6 @@ set_defaults("rtc_shared_library") {
suppressed_configs = []
}
webrtc_default_visibility = [ webrtc_root + "/*" ]
if (build_with_chromium) {
# Allow Chromium's WebRTC overrides targets to bypass the regular
# visibility restrictions.
webrtc_default_visibility += [ webrtc_root + "/../webrtc_overrides/*" ]
}
template("rtc_test") {
test(target_name) {
forward_variables_from(invoker,
@ -311,9 +304,6 @@ template("rtc_source_set") {
"visibility",
])
forward_variables_from(invoker, [ "visibility" ])
if (!defined(visibility)) {
visibility = webrtc_default_visibility
}
configs += invoker.configs
configs -= rtc_remove_configs
configs -= invoker.suppressed_configs
@ -336,9 +326,6 @@ template("rtc_executable") {
"visibility",
])
forward_variables_from(invoker, [ "visibility" ])
if (!defined(visibility)) {
visibility = webrtc_default_visibility
}
configs += invoker.configs
configs -= rtc_remove_configs
configs -= invoker.suppressed_configs
@ -365,9 +352,6 @@ template("rtc_static_library") {
"visibility",
])
forward_variables_from(invoker, [ "visibility" ])
if (!defined(visibility)) {
visibility = webrtc_default_visibility
}
configs += invoker.configs
configs -= rtc_remove_configs
configs -= invoker.suppressed_configs
@ -389,9 +373,6 @@ template("rtc_shared_library") {
"visibility",
])
forward_variables_from(invoker, [ "visibility" ])
if (!defined(visibility)) {
visibility = webrtc_default_visibility
}
configs += invoker.configs
configs -= rtc_remove_configs
configs -= invoker.suppressed_configs
@ -419,9 +400,6 @@ if (is_ios) {
"visibility",
])
forward_variables_from(invoker, [ "visibility" ])
if (!defined(visibility)) {
visibility = webrtc_default_visibility
}
configs += invoker.configs
configs -= rtc_remove_configs
configs -= invoker.suppressed_configs