zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Replace ASSERT(false) by RTC_NOTREACHED().

Browse Source 
This cl was produced by

  git grep -l 'ASSERT(false)' |\
    xargs -n1 sed -i 's/ASSERT(false)/RTC_NOTREACHED()/'

followed by additional includes of base/checks.h in affected files,
git cl format to adjust spacing in webrtc/base/transformadapter.cc.
Finally, to make presubmit happy, one unnamed TODO marker was deleted
in that file.

This is a step towards deletion of base/common.h.

BUG=webrtc:6424

Review-Url: https://codereview.webrtc.org/2625003003
Cr-Commit-Position: refs/heads/master@{#16009}
This commit is contained in:
nisse
2017-01-11 05:56:46 -08:00
committed by Commit bot
parent 10418acb97
commit c80e741ad0
36 changed files with 156 additions and 126 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
webrtc/base/win32socketserver.cc
View File

@ -14,6 +14,7 @@
#include <ws2tcpip.h> // NOLINT
#include "webrtc/base/byteorder.h"
#include "webrtc/base/checks.h"
#include "webrtc/base/common.h"
#include "webrtc/base/logging.h"
#include "webrtc/base/win32window.h"
@ -547,7 +548,7 @@ int Win32Socket::EstimateMTU(uint16_t* mtu) {
}
}
ASSERT(false);
RTC_NOTREACHED();
return 0;
}
@ -618,7 +619,7 @@ int Win32Socket::TranslateOption(Option opt, int* slevel, int* sopt) {
LOG(LS_WARNING) << "Socket::OPT_DSCP not supported.";
return -1;
default:
ASSERT(false);
RTC_NOTREACHED();
return -1;
}
return 0;