From c80f95511422fae261140e1eb3018d7cf88238b1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Erik=20Spr=C3=A5ng?= Date: Fri, 12 Mar 2021 16:36:49 +0100 Subject: [PATCH] Avoid log spam when decoder implementation changes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit A refactoring (https://webrtc-review.googlesource.com/c/src/+/196520) of decoder metadata handling introduced a bug which causes us to log an info-level entry for every frame decoded if the implementation changes during runtime (e.g. due to software fallback). This CL fixes that to avoid spamming the logs. Bug: webrtc:12271 Change-Id: I89016351b8752b259299c4cf56c6feddcca43460 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/211664 Reviewed-by: Åsa Persson Commit-Queue: Erik Språng Cr-Commit-Position: refs/heads/master@{#33451} --- modules/video_coding/generic_decoder.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/video_coding/generic_decoder.cc b/modules/video_coding/generic_decoder.cc index bd13d2186f..85c68dae1a 100644 --- a/modules/video_coding/generic_decoder.cc +++ b/modules/video_coding/generic_decoder.cc @@ -272,7 +272,7 @@ int32_t VCMGenericDecoder::Decode(const VCMEncodedFrame& frame, Timestamp now) { if (decoder_info != decoder_info_) { RTC_LOG(LS_INFO) << "Changed decoder implementation to: " << decoder_info.ToString(); - + decoder_info_ = decoder_info; _callback->OnDecoderImplementationName( decoder_info.implementation_name.empty() ? "unknown"