Stop using Googletest legacy APIs.

Googletest recently started replacing the term Test Case by Test Suite.
From now on, the preferred API is TestSuite*; the older TestCase* API
will be slowly deprecated.

This CL moves WebRTC to the new set of APIs.

More info in [1].

This CL has been generated with this script:

declare -A items
items[TYPED_TEST_CASE]=TYPED_TEST_SUITE
items[TYPED_TEST_CASE_P]=TYPED_TEST_SUITE_P
items[REGISTER_TYPED_TEST_CASE_P]=REGISTER_TYPED_TEST_SUITE_P
items[INSTANTIATE_TYPED_TEST_CASE_P]=INSTANTIATE_TYPED_TEST_SUITE_P
items[INSTANTIATE_TEST_CASE_P]=INSTANTIATE_TEST_SUITE_P
for i in "${!items[@]}"
do
  git ls-files | xargs sed -i "s/\b$i\b/${items[$i]}/g"
done
git cl format

[1] - https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature

Bug: None
Change-Id: I5ae191e3046caf347aeee01554d5743548ab0e3f
Reviewed-on: https://webrtc-review.googlesource.com/c/118701
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#26494}
This commit is contained in:
Mirko Bonadei
2019-01-31 12:20:57 +01:00
committed by Commit Bot
parent 12e5d392cc
commit c84f661b10
77 changed files with 354 additions and 347 deletions

View File

@ -443,7 +443,7 @@ TEST_P(DeltaEncodingTest, ZeroDelta) {
TestEncodingAndDecoding(base, values);
}
INSTANTIATE_TEST_CASE_P(
INSTANTIATE_TEST_SUITE_P(
SignednessOverrideAndNumberOfValuesInSequence,
DeltaEncodingTest,
::testing::Combine(::testing::Values(DeltaSignedness::kNoOverride,
@ -555,7 +555,7 @@ TEST_P(DeltaEncodingCompressionQualityTest,
}
}
INSTANTIATE_TEST_CASE_P(
INSTANTIATE_TEST_SUITE_P(
SignednessOverrideAndDeltaMaxBitWidthAndNumberOfValuesInSequence,
DeltaEncodingCompressionQualityTest,
::testing::Combine(
@ -616,7 +616,7 @@ TEST_P(DeltaEncodingFuzzerLikeTest, Test) {
TestEncodingAndDecoding(base, values);
}
INSTANTIATE_TEST_CASE_P(
INSTANTIATE_TEST_SUITE_P(
SignednessOverrideAndDeltaMaxBitWidthAndNumberOfValuesInSequence,
DeltaEncodingFuzzerLikeTest,
::testing::Combine(
@ -679,7 +679,7 @@ TEST_P(DeltaEncodingSpecificEdgeCasesTest, ReverseSequence) {
TestEncodingAndDecoding(base, values);
}
INSTANTIATE_TEST_CASE_P(
INSTANTIATE_TEST_SUITE_P(
_,
DeltaEncodingSpecificEdgeCasesTest,
::testing::Combine(

View File

@ -27,7 +27,7 @@ class SignednessConversionTest : public testing::Test {
static_assert(std::is_signed<T>::value, "");
};
TYPED_TEST_CASE_P(SignednessConversionTest);
TYPED_TEST_SUITE_P(SignednessConversionTest);
TYPED_TEST_P(SignednessConversionTest, CorrectlyConvertsLegalValues) {
using T = TypeParam;
@ -72,13 +72,13 @@ TYPED_TEST_P(SignednessConversionTest, FailsOnConvertingIllegalValues) {
}
}
REGISTER_TYPED_TEST_CASE_P(SignednessConversionTest,
CorrectlyConvertsLegalValues,
FailsOnConvertingIllegalValues);
REGISTER_TYPED_TEST_SUITE_P(SignednessConversionTest,
CorrectlyConvertsLegalValues,
FailsOnConvertingIllegalValues);
using Types = ::testing::Types<int8_t, int16_t, int32_t, int64_t>;
INSTANTIATE_TYPED_TEST_CASE_P(_, SignednessConversionTest, Types);
INSTANTIATE_TYPED_TEST_SUITE_P(_, SignednessConversionTest, Types);
} // namespace
} // namespace webrtc_event_logging

View File

@ -939,7 +939,7 @@ TEST_P(RtcEventLogEncoderTest, RtcEventVideoSendStreamConfig) {
verifier_.VerifyLoggedVideoSendConfig(*event, video_send_configs[0]);
}
INSTANTIATE_TEST_CASE_P(
INSTANTIATE_TEST_SUITE_P(
RandomSeeds,
RtcEventLogEncoderTest,
::testing::Combine(/* Random seed*: */ ::testing::Values(1, 2, 3, 4, 5),

View File

@ -725,7 +725,7 @@ TEST_P(RtcEventLogSession, StartLoggingInTheMiddle) {
ReadAndVerifyLog();
}
INSTANTIATE_TEST_CASE_P(
INSTANTIATE_TEST_SUITE_P(
RtcEventLogTest,
RtcEventLogSession,
::testing::Combine(
@ -822,7 +822,7 @@ TEST_P(RtcEventLogCircularBufferTest, KeepsMostRecentEvents) {
}
}
INSTANTIATE_TEST_CASE_P(
INSTANTIATE_TEST_SUITE_P(
RtcEventLogTest,
RtcEventLogCircularBufferTest,
::testing::Values(RtcEventLog::EncodingType::Legacy,