zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reland of PyLint fixes for tools-webrtc and webrtc/tools (patchset #1 id:1 of https://codereview.webrtc.org/2737233003/ )

Browse Source 
Reason for revert:
Fixing errors for reland. I have tested that this does not make Chromium video quality tests fail.

Original issue's description:
> Revert of PyLint fixes for tools-webrtc and webrtc/tools (patchset #3 id:40001 of https://codereview.webrtc.org/2736233003/ )
>
> Reason for revert:
> Fails video quality tests in Chrome:  http://build.chromium.org/p/chromium.webrtc.fyi/builders/Win10%20Tester/builds/6568
> I should have looked more closer at those :(
>
> Original issue's description:
> > PyLint fixes for tools-webrtc and webrtc/tools
> >
> > Fix a lot of errors before bringing in the new config in
> > https://codereview.webrtc.org/2737963003/
> >
> > BUG=webrtc:7303
> > NOTRY=True
> >
> > Review-Url: https://codereview.webrtc.org/2736233003
> > Cr-Commit-Position: refs/heads/master@{#17137}
> > Committed: f5318e1f39
>
> TBR=oprypin@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:7303
>
> Review-Url: https://codereview.webrtc.org/2737233003
> Cr-Commit-Position: refs/heads/master@{#17142}
> Committed: 94f4d9effc

NOTRY=true
BUG=webrtc:7312

Review-Url: https://codereview.webrtc.org/2741733003
Cr-Commit-Position: refs/heads/master@{#17541}
This commit is contained in:
kjellander
2017-04-05 06:42:43 -07:00
committed by Commit bot
parent adf0635ed5
commit c88b5d56ad
15 changed files with 154 additions and 157 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tools-webrtc/check_package_boundaries.py
View File

@ -39,7 +39,7 @@ class Logger(object):
self.log_level = DISPLAY_LEVEL
self.messages_left = messages_left
def log(self, build_file_path, line_number, target_name, source_file,
def Log(self, build_file_path, line_number, target_name, source_file,
subpackage):
if self.messages_left is not None:
if not self.messages_left:
@ -91,7 +91,7 @@ def _CheckBuildFile(build_file_path, packages, logger):
line_number = subpackages_match.group('line_number')
if subpackage:
found_violations = True
logger.log(build_file_path, line_number, target_name, source_file,
logger.Log(build_file_path, line_number, target_name, source_file,
subpackage)
return found_violations