Remove objc tests from rtc_unittests and move tests to sdk_unittests
The tests in rtc_unittests_objc are old gtest based tests and The tests in sdk_unittests are XCTest based tests. The objc tests in rtc_unittest are causing problems [1], so I think it's time to combine the two types of objc tests. Renaming the files to match the existing sdk_unittests and removing the use of gtest helper functions (eg, EXPECT_EQ) are planned for follow-up CLs. [1] https://webrtc-review.googlesource.com/c/src/+/261724/9 Bug: webrtc:8382 Change-Id: I9308b35f654c4479c9df72bf7cd7f4032e267eb2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262380 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Daniel.L (Byoungchan) Lee <daniel.l@hpcnt.com> Reviewed-by: Kári Helgason <kthelgason@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36878}
This commit is contained in:
committed by
WebRTC LUCI CQ
parent
cbb8fb8337
commit
c8a6fb2bb8
@ -9,6 +9,7 @@
|
||||
*/
|
||||
|
||||
#import <Foundation/Foundation.h>
|
||||
#import <XCTest/XCTest.h>
|
||||
|
||||
#include <vector>
|
||||
|
||||
@ -17,11 +18,10 @@
|
||||
#import "api/peerconnection/RTCTracing.h"
|
||||
#import "helpers/NSString+StdString.h"
|
||||
|
||||
@interface RTCTracingTest : NSObject
|
||||
- (void)tracingTestNoInitialization;
|
||||
@interface RTCTracingTests : XCTestCase
|
||||
@end
|
||||
|
||||
@implementation RTCTracingTest
|
||||
@implementation RTCTracingTests
|
||||
|
||||
- (NSString *)documentsFilePathForFileName:(NSString *)fileName {
|
||||
NSParameterAssert(fileName.length);
|
||||
@ -32,17 +32,10 @@
|
||||
return filePath;
|
||||
}
|
||||
|
||||
- (void)tracingTestNoInitialization {
|
||||
- (void)testTracingTestNoInitialization {
|
||||
NSString *filePath = [self documentsFilePathForFileName:@"webrtc-trace.txt"];
|
||||
EXPECT_EQ(NO, RTCStartInternalCapture(filePath));
|
||||
RTCStopInternalCapture();
|
||||
}
|
||||
|
||||
@end
|
||||
|
||||
TEST(RTCTracingTest, TracingTestNoInitialization) {
|
||||
@autoreleasepool {
|
||||
RTCTracingTest *test = [[RTCTracingTest alloc] init];
|
||||
[test tracingTestNoInitialization];
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user