zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "opus: take SILK vad result into account for voice detection"

Browse Source 
This reverts commit 686a3709acfedcf0a4c798dd1c5902787c4a266b.

Reason for revert: crbug.com/1144220

Original change's description:
> opus: take SILK vad result into account for voice detection
>
> BUG=webrtc:11643
>
> Change-Id: Idc3a9b6bb7bd1a33f905843e5d6067ae19d5172c
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176508
> Commit-Queue: Minyue Li <minyue@webrtc.org>
> Reviewed-by: Minyue Li <minyue@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#31743}

TBR=devicentepena@webrtc.org,minyue@webrtc.org,fippo@sip-communicator.org

Bug: webrtc:11643
Change-Id: I9c77e4f6e919c4b648a5783edf4188e1f8114602
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/191485
Commit-Queue: Minyue Li <minyue@webrtc.org>
Reviewed-by: Minyue Li <minyue@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32542}
This commit is contained in:
Minyue Li
2020-11-03 23:22:26 +01:00
committed by Commit Bot
parent ddd41919c0
commit c940870b72
5 changed files with 23 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
modules/audio_coding/codecs/opus/opus_unittest.cc
View File

@ -975,21 +975,4 @@ TEST(OpusVadTest, TwoOpusMonoFramesVadOnSecond) {
EXPECT_TRUE(WebRtcOpus_PacketHasVoiceActivity(twoMonoFrames, 3));
}
TEST(OpusVadTest, DtxEmptyPacket) {
const uint8_t dtx[] = {0x78};
EXPECT_FALSE(WebRtcOpus_PacketHasVoiceActivity(dtx, 1));
}
TEST(OpusVadTest, DtxBackgroundNoisePacket) {
// DTX sends a frame coding background noise every 20 packets:
// https://tools.ietf.org/html/rfc6716#section-2.1.9
// The packet below represents such a frame and was captured using
// Wireshark while disabling encryption.
const uint8_t dtx[] = {0x78, 0x07, 0xc9, 0x79, 0xc8, 0xc9, 0x57, 0xc0, 0xa2,
0x12, 0x23, 0xfa, 0xef, 0x67, 0xf3, 0x2e, 0xe3, 0xd3,
0xd5, 0xe9, 0xec, 0xdb, 0x3e, 0xbc, 0x80, 0xb6, 0x6e,
0x2a, 0xb7, 0x8c, 0x83, 0xcd, 0x83, 0xcd, 0x00};
EXPECT_FALSE(WebRtcOpus_PacketHasVoiceActivity(dtx, 35));
}
} // namespace webrtc