zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Disable TestUdpReadyToSendIPv4 under MSan.

Browse Source 
It has become extra flaky lately, and is preventing people from
using the CQ.

BUG=webrtc:4958

Review URL: https://codereview.webrtc.org/1368763002

Cr-Commit-Position: refs/heads/master@{#10080}
This commit is contained in:
deadbeef
2015-09-25 11:00:38 -07:00
committed by Commit bot
parent 4d47aa335c
commit c97be6a741
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
webrtc/base/physicalsocketserver_unittest.cc
View File

@ -211,13 +211,16 @@ TEST_F(PhysicalSocketTest, MAYBE_TestUdpIPv6) {
// Disable for TSan v2, see // Disable for TSan v2, see
// https://code.google.com/p/webrtc/issues/detail?id=3498 for details. // https://code.google.com/p/webrtc/issues/detail?id=3498 for details.
#if !defined(THREAD_SANITIZER) // Also disable for MSan, see:
// https://code.google.com/p/webrtc/issues/detail?id=4958
// TODO(deadbeef): Enable again once test is reimplemented to be unflaky.
#if !defined(THREAD_SANITIZER) && !defined(MEMORY_SANITIZER)
TEST_F(PhysicalSocketTest, TestUdpReadyToSendIPv4) { TEST_F(PhysicalSocketTest, TestUdpReadyToSendIPv4) {
SocketTest::TestUdpReadyToSendIPv4(); SocketTest::TestUdpReadyToSendIPv4();
} }
#endif // if !defined(THREAD_SANITIZER) #endif // if !defined(THREAD_SANITIZER) && !defined(MEMORY_SANITIZER)
TEST_F(PhysicalSocketTest, TestUdpReadyToSendIPv6) { TEST_F(PhysicalSocketTest, TestUdpReadyToSendIPv6) {
SocketTest::TestUdpReadyToSendIPv6(); SocketTest::TestUdpReadyToSendIPv6();