zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove AudioEncoder methods SetMaxBitrate and SetMaxPayloadSize

Browse Source 
And the corresponding ACM methods SetISACMaxRate and
SetISACMaxPayloadSize. They were only used in tests.

Review URL: https://codereview.webrtc.org/1311533010

Cr-Commit-Position: refs/heads/master@{#9903}
This commit is contained in:
kwiberg
2015-09-09 00:54:07 -07:00
committed by Commit bot
parent d944067a03
commit c99ebc1490
13 changed files with 0 additions and 158 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.cc
View File

@ -739,30 +739,6 @@ int AudioCodingModuleImpl::IncomingPayload(const uint8_t* incoming_payload,
return 0;
}
// TODO(henrik.lundin): Remove? Only used in tests. Deprecated in VoiceEngine.
int AudioCodingModuleImpl::SetISACMaxRate(int max_bit_per_sec) {
CriticalSectionScoped lock(acm_crit_sect_.get());
if (!HaveValidEncoder("SetISACMaxRate")) {
return -1;
}
codec_manager_.CurrentEncoder()->SetMaxBitrate(max_bit_per_sec);
return 0;
}
// TODO(henrik.lundin): Remove? Only used in tests. Deprecated in VoiceEngine.
int AudioCodingModuleImpl::SetISACMaxPayloadSize(int max_size_bytes) {
CriticalSectionScoped lock(acm_crit_sect_.get());
if (!HaveValidEncoder("SetISACMaxPayloadSize")) {
return -1;
}
codec_manager_.CurrentEncoder()->SetMaxPayloadSize(max_size_bytes);
return 0;
}
int AudioCodingModuleImpl::SetOpusApplication(OpusApplicationMode application) {
CriticalSectionScoped lock(acm_crit_sect_.get());
if (!HaveValidEncoder("SetOpusApplication")) {

4
webrtc/modules/audio_coding/main/acm2/audio_coding_module_impl.h
View File

@ -185,10 +185,6 @@ class AudioCodingModuleImpl final : public AudioCodingModule {
int GetNetworkStatistics(NetworkStatistics* statistics) override;
int SetISACMaxRate(int max_bit_per_sec) override;
int SetISACMaxPayloadSize(int max_size_bytes) override;
int SetOpusApplication(OpusApplicationMode application) override;
// If current send codec is Opus, informs it about the maximum playback rate