zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete obsolete method QueryVideoEncoder

Browse Source 
Bug: webrtc:12875
Change-Id: Icc2f3ceb9814292755b9c382186e27f3131b64a2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/237280
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35376}
This commit is contained in:
Niels Möller
2021-11-16 12:48:13 +01:00
committed by WebRTC LUCI CQ
parent 0a7a8e0aba
commit cabc3e50dd
2 changed files with 1 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
api/video_codecs/video_encoder_factory.h
View File

@ -27,10 +27,6 @@ class VideoEncoder;
// NOTE: This class is still under development and may change without notice.
class VideoEncoderFactory {
public:
// TODO(magjed): Try to get rid of this struct.
struct CodecInfo {
};
struct CodecSupport {
bool is_supported = false;
bool is_power_efficient = false;
@ -68,16 +64,6 @@ class VideoEncoderFactory {
return GetSupportedFormats();
}
// Returns information about how this format will be encoded. The specified
// format must be one of the supported formats by this factory.
// TODO(magjed): Try to get rid of this method. Since is_hardware_accelerated
// is unused, only factories producing internal source encoders (in itself a
// deprecated feature) needs to override this method.
virtual CodecInfo QueryVideoEncoder(const SdpVideoFormat& format) const {
return CodecInfo();
}
// Query whether the specifed format is supported or not and if it will be
// power efficient, which is currently interpreted as if there is support for
// hardware acceleration.

1
test/peer_scenario/peer_scenario_client.cc
View File

@ -174,6 +174,7 @@ class FakeVideoEncoderFactory : public VideoEncoderFactory {
}
std::unique_ptr<VideoEncoder> CreateVideoEncoder(
const SdpVideoFormat& format) override {
RTC_CHECK_EQ(format.name, "VP8");
return std::make_unique<FakeVp8Encoder>(clock_);
}