zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove pointless move() to fix build on clang/win.

Browse Source 
Fixes:
..\..\third_party\libjingle\source\talk\app\webrtc\remoteaudiosource.cc(100,15)
: error: moving a temporary object prevents copy elision
[-Werror,-Wpessimizing-move]
        ssrc, std::move(rtc::scoped_ptr<AudioSinkInterface>(new Sink(this))));
              ^
..\..\third_party\libjingle\source\talk\app\webrtc\remoteaudiosource.cc(100,15)
:  note: remove std::move call here
        ssrc, std::move(rtc::scoped_ptr<AudioSinkInterface>(new Sink(this))));
              ^~~~~~~~~~

R=thakis@chromium.org
TBR=thakis@chromium.org

Review URL: https://codereview.webrtc.org/1517253004 .

Cr-Commit-Position: refs/heads/master@{#10999}
This commit is contained in:
Tommi
2015-12-12 16:54:32 +01:00
parent 66679dcc04
commit cb95f54ee4
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
talk/app/webrtc/remoteaudiosource.cc
View File

@ -97,7 +97,7 @@ void RemoteAudioSource::Initialize(uint32_t ssrc,
// we register for callbacks here and not on demand in AddSink. // we register for callbacks here and not on demand in AddSink.
if (provider) { // May be null in tests. if (provider) { // May be null in tests.
provider->SetRawAudioSink( provider->SetRawAudioSink(
ssrc, std::move(rtc::scoped_ptr<AudioSinkInterface>(new Sink(this)))); ssrc, rtc::scoped_ptr<AudioSinkInterface>(new Sink(this)));
} }
} }