Update/delete old TODOs
Bug: webrtc:10198 Change-Id: I0341e068d792bc0b143db86e675988f4cd07ff2e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267822 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/main@{#37454}
This commit is contained in:

committed by
WebRTC LUCI CQ

parent
6183a0fe9a
commit
cb99ccd244
@ -110,7 +110,6 @@ static void RtpFragmentize(EncodedImage* encoded_image, SFrameBSInfo* info) {
|
||||
required_capacity += layerInfo.pNalLengthInByte[nal];
|
||||
}
|
||||
}
|
||||
// TODO(nisse): Use a cache or buffer pool to avoid allocation?
|
||||
auto buffer = EncodedImageBuffer::Create(required_capacity);
|
||||
encoded_image->SetEncodedData(buffer);
|
||||
|
||||
|
@ -116,7 +116,7 @@ MultiplexImageComponentHeader UnpackFrameHeader(const uint8_t* buffer) {
|
||||
ByteReader<uint32_t>::ReadBigEndian(buffer + offset);
|
||||
offset += sizeof(uint32_t);
|
||||
|
||||
// TODO(nisse): This makes the wire format depend on the numeric values of the
|
||||
// This makes the wire format depend on the numeric values of the
|
||||
// VideoCodecType and VideoFrameType enum constants.
|
||||
frame_header.codec_type = static_cast<VideoCodecType>(
|
||||
ByteReader<uint8_t>::ReadBigEndian(buffer + offset));
|
||||
|
@ -1125,8 +1125,6 @@ int LibvpxVp8Encoder::GetEncodedPartitions(const VideoFrame& input_image,
|
||||
}
|
||||
}
|
||||
|
||||
// TODO(nisse): Introduce some buffer cache or buffer pool, to reduce
|
||||
// allocations and/or copy operations.
|
||||
auto buffer = EncodedImageBuffer::Create(encoded_size);
|
||||
|
||||
iter = NULL;
|
||||
|
@ -1706,8 +1706,6 @@ void LibvpxVp9Encoder::GetEncodedLayerFrame(const vpx_codec_cx_pkt* pkt) {
|
||||
DeliverBufferedFrame(end_of_picture);
|
||||
}
|
||||
|
||||
// TODO(nisse): Introduce some buffer cache or buffer pool, to reduce
|
||||
// allocations and/or copy operations.
|
||||
encoded_image_.SetEncodedData(EncodedImageBuffer::Create(
|
||||
static_cast<const uint8_t*>(pkt->data.frame.buf), pkt->data.frame.sz));
|
||||
|
||||
|
@ -58,7 +58,6 @@ VCMPacket::VCMPacket(const uint8_t* ptr,
|
||||
completeNALU = kNaluIncomplete;
|
||||
}
|
||||
|
||||
// TODO(nisse): Delete?
|
||||
// Playout decisions are made entirely based on first packet in a frame.
|
||||
if (!is_first_packet_in_frame()) {
|
||||
video_header.playout_delay = {-1, -1};
|
||||
|
@ -49,7 +49,6 @@ class VCMSessionInfo {
|
||||
// Returns the number of bytes deleted from the session.
|
||||
size_t MakeDecodable();
|
||||
|
||||
// TODO(nisse): Used by tests only.
|
||||
size_t SessionLength() const;
|
||||
int NumPackets() const;
|
||||
bool HaveFirstPacket() const;
|
||||
|
@ -31,7 +31,6 @@
|
||||
namespace webrtc {
|
||||
|
||||
namespace {
|
||||
// TODO(nisse): Delete, delegate to encoders.
|
||||
// Threshold constant used until first downscale (to permit fast rampup).
|
||||
static const int kMeasureMs = 2000;
|
||||
static const float kSamplePeriodScaleFactor = 2.5;
|
||||
|
Reference in New Issue
Block a user