zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reformat GN files.

Browse Source 
`gn format` recently [1] changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

CL generated with:
$ git ls-files | grep BUILD.gn | xargs gn format
$ gn format build_overrides/build.gni
$ gn format build_overrides/gtest.gni
$ gn format modules/audio_coding/audio_coding.gni
$ gn format webrtc.gni
$ gn format .gn

Plus a few manual changes to add exceptions for
"public_deps" (after changing these lines the presubmit
started to complain).

[1] - https://gn-review.googlesource.com/c/gn/+/6860

Bug: webrtc:11302
Change-Id: Iac29d23c1618ebef925c972e2891cd9f4e8cd613
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166882
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#30334}
This commit is contained in:
Mirko Bonadei
2020-01-21 12:10:10 +01:00
committed by Commit Bot
parent 0809e7ed43
commit ccbe95fd8a
67 changed files with 382 additions and 1132 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
modules/audio_processing/test/conversational_speech/BUILD.gn
View File

@ -10,16 +10,12 @@ import("../../../../webrtc.gni")
group("conversational_speech") {
testonly = true
deps = [
":conversational_speech_generator",
]
deps = [ ":conversational_speech_generator" ]
}
rtc_executable("conversational_speech_generator") {
testonly = true
sources = [
"generator.cc",
]
sources = [ "generator.cc" ]
deps = [
":lib",
"../../../../test:fileutils",

53
modules/audio_processing/test/py_quality_assessment/BUILD.gn
View File

@ -27,9 +27,7 @@ copy("scripts") {
"apm_quality_assessment_gencfgs.py",
"apm_quality_assessment_optimize.py",
]
outputs = [
"$root_build_dir/py_quality_assessment/{{source_file_part}}",
]
outputs = [ "$root_build_dir/py_quality_assessment/{{source_file_part}}" ]
deps = [
":apm_configs",
":lib",
@ -41,9 +39,7 @@ copy("scripts") {
copy("apm_configs") {
testonly = true
sources = [
"apm_configs/default.json",
]
sources = [ "apm_configs/default.json" ]
visibility = [ ":*" ] # Only targets in this file can depend on this.
outputs = [
"$root_build_dir/py_quality_assessment/apm_configs/{{source_file_part}}",
@ -77,23 +73,16 @@ copy("lib") {
"quality_assessment/test_data_generation_factory.py",
]
visibility = [ ":*" ] # Only targets in this file can depend on this.
outputs = [
"$root_build_dir/py_quality_assessment/quality_assessment/{{source_file_part}}",
]
deps = [
"../../../../resources/audio_processing/test/py_quality_assessment:noise_tracks",
]
outputs = [ "$root_build_dir/py_quality_assessment/quality_assessment/{{source_file_part}}" ]
deps = [ "../../../../resources/audio_processing/test/py_quality_assessment:noise_tracks" ]
}
copy("output") {
testonly = true
sources = [
"output/README.md",
]
sources = [ "output/README.md" ]
visibility = [ ":*" ] # Only targets in this file can depend on this.
outputs = [
"$root_build_dir/py_quality_assessment/output/{{source_file_part}}",
]
outputs =
[ "$root_build_dir/py_quality_assessment/output/{{source_file_part}}" ]
}
group("unit_tests") {
@ -110,9 +99,7 @@ group("unit_tests") {
rtc_executable("fake_polqa") {
testonly = true
sources = [
"quality_assessment/fake_polqa.cc",
]
sources = [ "quality_assessment/fake_polqa.cc" ]
visibility = [ ":*" ] # Only targets in this file can depend on this.
output_dir = "${root_out_dir}/py_quality_assessment/quality_assessment"
deps = [
@ -123,9 +110,7 @@ rtc_executable("fake_polqa") {
rtc_executable("vad") {
testonly = true
sources = [
"quality_assessment/vad.cc",
]
sources = [ "quality_assessment/vad.cc" ]
deps = [
"../../../../common_audio",
"../../../../rtc_base:rtc_base_approved",
@ -136,9 +121,7 @@ rtc_executable("vad") {
rtc_executable("apm_vad") {
testonly = true
sources = [
"quality_assessment/apm_vad.cc",
]
sources = [ "quality_assessment/apm_vad.cc" ]
deps = [
"../..",
"../../../../common_audio",
@ -151,9 +134,7 @@ rtc_executable("apm_vad") {
rtc_executable("sound_level") {
testonly = true
sources = [
"quality_assessment/sound_level.cc",
]
sources = [ "quality_assessment/sound_level.cc" ]
deps = [
"../..",
"../../../../common_audio",
@ -176,18 +157,12 @@ copy("lib_unit_tests") {
"quality_assessment/test_data_generation_unittest.py",
]
visibility = [ ":*" ] # Only targets in this file can depend on this.
outputs = [
"$root_build_dir/py_quality_assessment/quality_assessment/{{source_file_part}}",
]
outputs = [ "$root_build_dir/py_quality_assessment/quality_assessment/{{source_file_part}}" ]
}
copy("scripts_unit_tests") {
testonly = true
sources = [
"apm_quality_assessment_unittest.py",
]
sources = [ "apm_quality_assessment_unittest.py" ]
visibility = [ ":*" ] # Only targets in this file can depend on this.
outputs = [
"$root_build_dir/py_quality_assessment/{{source_file_part}}",
]
outputs = [ "$root_build_dir/py_quality_assessment/{{source_file_part}}" ]
}