zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[DVQA] Remove old dropped_by_encoder and dropped_before_encoder stats fields

Browse Source 
Bug: None
Change-Id: I1717eaddb1703890c79b02d109a1e4623bfc5259
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/229983
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#34840}
This commit is contained in:
Artem Titov
2021-08-24 20:55:59 +02:00
committed by WebRTC LUCI CQ
parent 02334e07c5
commit cdab136fce
3 changed files with 0 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
test/pc/e2e/analyzer/video/default_video_quality_analyzer.cc
View File

@ -66,10 +66,6 @@ void LogStreamInternalStats(const std::string& name,
RTC_LOG(INFO) << "[" << name << "] Dropped at " << ToString(entry.first) RTC_LOG(INFO) << "[" << name << "] Dropped at " << ToString(entry.first)
<< ": " << entry.second; << ": " << entry.second;
} }
RTC_LOG(INFO) << "[" << name
<< "] Dropped by encoder : " << stats.dropped_by_encoder;
RTC_LOG(INFO) << "[" << name << "] Dropped before encoder : "
<< stats.dropped_before_encoder;
Timestamp first_encoded_frame_time = Timestamp::PlusInfinity(); Timestamp first_encoded_frame_time = Timestamp::PlusInfinity();
for (const StreamCodecInfo& encoder : stats.encoders) { for (const StreamCodecInfo& encoder : stats.encoders) {
RTC_DCHECK(encoder.switched_on_at.IsFinite()); RTC_DCHECK(encoder.switched_on_at.IsFinite());

6
test/pc/e2e/analyzer/video/default_video_quality_analyzer_frames_comparator.cc
View File

@ -427,12 +427,6 @@ void DefaultVideoQualityAnalyzerFramesComparator::ProcessComparison(
stats->total_encoded_images_payload += frame_stats.encoded_image_size; stats->total_encoded_images_payload += frame_stats.encoded_image_size;
stats->target_encode_bitrate.AddSample(StatsSample( stats->target_encode_bitrate.AddSample(StatsSample(
frame_stats.target_encode_bitrate, frame_stats.encoded_time)); frame_stats.target_encode_bitrate, frame_stats.encoded_time));
} else {
if (frame_stats.pre_encode_time.IsFinite()) {
stats->dropped_by_encoder++;
} else {
stats->dropped_before_encoder++;
}
} }
// Next stats can be calculated only if frame was received on remote side. // Next stats can be calculated only if frame was received on remote side.
if (comparison.type != FrameComparisonType::kDroppedFrame) { if (comparison.type != FrameComparisonType::kDroppedFrame) {

2
test/pc/e2e/analyzer/video/default_video_quality_analyzer_shared_objects.h
View File

@ -125,8 +125,6 @@ struct StreamStats {
SamplesStatsCounter target_encode_bitrate; SamplesStatsCounter target_encode_bitrate;
int64_t total_encoded_images_payload = 0; int64_t total_encoded_images_payload = 0;
int64_t dropped_by_encoder = 0;
int64_t dropped_before_encoder = 0;
// Counters on which phase how many frames were dropped. // Counters on which phase how many frames were dropped.
std::map<FrameDropPhase, int64_t> dropped_by_phase; std::map<FrameDropPhase, int64_t> dropped_by_phase;