zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[iOS] Fixed RTC_DCHECK_NOTREACHED

Browse Source 
Bug: None
Change-Id: I93f716a1e9c1b08e2bc1dc96ad282e66ef0dfaf2
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/256962
Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
Commit-Queue: Yury Yarashevich <yura.yaroshevich@gmail.com>
Cr-Commit-Position: refs/heads/main@{#36354}
This commit is contained in:
Yura Yaroshevich
2022-03-28 14:20:05 +02:00
committed by WebRTC LUCI CQ
parent e0c6bdf071
commit cf9094a26e
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
sdk/objc/api/logging/RTCCallbackLogger.mm
View File

@ -19,7 +19,9 @@
#include "rtc_base/log_sinks.h"
#include "rtc_base/logging.h"
class CallbackLogSink : public rtc::LogSink {
namespace {
class CallbackLogSink final : public rtc::LogSink {
public:
CallbackLogSink(RTCCallbackLoggerMessageHandler callbackHandler)
: callback_handler_(callbackHandler) {}
@ -38,13 +40,17 @@ class CallbackLogSink : public rtc::LogSink {
RTCCallbackLoggerMessageHandler callback_handler_;
};
class CallbackWithSeverityLogSink : public rtc::LogSink {
class CallbackWithSeverityLogSink final : public rtc::LogSink {
public:
CallbackWithSeverityLogSink(RTCCallbackLoggerMessageAndSeverityHandler callbackHandler)
: callback_handler_(callbackHandler) {}
void OnLogMessage(const std::string& message) override { RTC_DCHECK_NOTREACHED(); }
void OnLogMessage(const std::string& message, rtc::LoggingSeverity severity) override {
OnLogMessage(absl::string_view(message), severity);
}
void OnLogMessage(absl::string_view message, rtc::LoggingSeverity severity) override {
if (callback_handler_) {
RTCLoggingSeverity loggingSeverity = NativeSeverityToObjcSeverity(severity);
@ -71,6 +77,8 @@ class CallbackWithSeverityLogSink : public rtc::LogSink {
RTCCallbackLoggerMessageAndSeverityHandler callback_handler_;
};
}
@implementation RTC_OBJC_TYPE (RTCCallbackLogger) {
BOOL _hasStarted;
std::unique_ptr<rtc::LogSink> _logSink;