From cfb7f01fd627c666041355a69e70fa06ce149ece Mon Sep 17 00:00:00 2001 From: honghaiz Date: Mon, 21 Dec 2015 13:34:54 -0800 Subject: [PATCH] Disable VideoSendStreamTest.ReconfigureBitratesSetsEncoderBitratesCorrectly due to flakiness on LinuxAsan. BUG=webrtc:5382 TBR=kjellander@webrtc.org Review URL: https://codereview.webrtc.org/1541923003 Cr-Commit-Position: refs/heads/master@{#11109} --- webrtc/video/video_send_stream_tests.cc | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/webrtc/video/video_send_stream_tests.cc b/webrtc/video/video_send_stream_tests.cc index f48f7b7847..14230e540b 100644 --- a/webrtc/video/video_send_stream_tests.cc +++ b/webrtc/video/video_send_stream_tests.cc @@ -1652,7 +1652,18 @@ TEST_F(VideoSendStreamTest, TranslatesTwoLayerScreencastToTargetBitrate) { RunBaseTest(&test, FakeNetworkPipe::Config()); } -TEST_F(VideoSendStreamTest, ReconfigureBitratesSetsEncoderBitratesCorrectly) { +// Disabled on LinuxAsan: +// https://bugs.chromium.org/p/webrtc/issues/detail?id=5382 +#if defined(ADDRESS_SANITIZER) && defined(WEBRTC_LINUX) +#define MAYBE_ReconfigureBitratesSetsEncoderBitratesCorrectly \ + DISABLED_ReconfigureBitratesSetsEncoderBitratesCorrectly +#else +#define MAYBE_ReconfigureBitratesSetsEncoderBitratesCorrectly \ + ReconfigureBitratesSetsEncoderBitratesCorrectly +#endif + +TEST_F(VideoSendStreamTest, + MAYBE_ReconfigureBitratesSetsEncoderBitratesCorrectly) { // These are chosen to be "kind of odd" to not be accidentally checked against // default values. static const int kMinBitrateKbps = 137;