zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unused FlexfecReceiveStream::Stats struct

Browse Source 
Bug: webrtc:14109
Change-Id: Ie06c267c15b21eff15803ead11b6deb661d17523
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262944
Reviewed-by: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Rasmus Brandt <brandtr@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#36996}
This commit is contained in:
Rasmus Brandt
2022-05-20 14:55:32 +02:00
committed by WebRTC LUCI CQ
parent 02d65d7ec5
commit cfc79174f2
5 changed files with 0 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
call/flexfec_receive_stream.h
View File

@ -29,13 +29,6 @@ class FlexfecReceiveStream : public RtpPacketSinkInterface,
public: public:
~FlexfecReceiveStream() override = default; ~FlexfecReceiveStream() override = default;
struct Stats {
std::string ToString(int64_t time_ms) const;
// TODO(brandtr): Add appropriate stats here.
int flexfec_bitrate_bps;
};
struct Config { struct Config {
explicit Config(Transport* rtcp_send_transport); explicit Config(Transport* rtcp_send_transport);
Config(const Config&); Config(const Config&);
@ -66,8 +59,6 @@ class FlexfecReceiveStream : public RtpPacketSinkInterface,
// Transport for outgoing RTCP packets. // Transport for outgoing RTCP packets.
Transport* rtcp_send_transport = nullptr; Transport* rtcp_send_transport = nullptr;
}; };
virtual Stats GetStats() const = 0;
}; };
} // namespace webrtc } // namespace webrtc

14
call/flexfec_receive_stream_impl.cc
View File

@ -31,14 +31,6 @@
namespace webrtc { namespace webrtc {
std::string FlexfecReceiveStream::Stats::ToString(int64_t time_ms) const {
char buf[1024];
rtc::SimpleStringBuilder ss(buf);
ss << "FlexfecReceiveStream stats: " << time_ms
<< ", {flexfec_bitrate_bps: " << flexfec_bitrate_bps << "}";
return ss.str();
}
std::string FlexfecReceiveStream::Config::ToString() const { std::string FlexfecReceiveStream::Config::ToString() const {
char buf[1024]; char buf[1024];
rtc::SimpleStringBuilder ss(buf); rtc::SimpleStringBuilder ss(buf);
@ -196,12 +188,6 @@ void FlexfecReceiveStreamImpl::OnRtpPacket(const RtpPacketReceived& packet) {
} }
} }
// TODO(brandtr): Implement this member function when we have designed the
// stats for FlexFEC.
FlexfecReceiveStreamImpl::Stats FlexfecReceiveStreamImpl::GetStats() const {
return FlexfecReceiveStream::Stats();
}
void FlexfecReceiveStreamImpl::SetRtpExtensions( void FlexfecReceiveStreamImpl::SetRtpExtensions(
std::vector<RtpExtension> extensions) { std::vector<RtpExtension> extensions) {
RTC_DCHECK_RUN_ON(&packet_sequence_checker_); RTC_DCHECK_RUN_ON(&packet_sequence_checker_);

3
call/flexfec_receive_stream_impl.h
View File

@ -55,9 +55,6 @@ class FlexfecReceiveStreamImpl : public FlexfecReceiveStream {
// RtpPacketSinkInterface. // RtpPacketSinkInterface.
void OnRtpPacket(const RtpPacketReceived& packet) override; void OnRtpPacket(const RtpPacketReceived& packet) override;
Stats GetStats() const override;
// ReceiveStreamInterface impl. // ReceiveStreamInterface impl.
void SetRtpExtensions(std::vector<RtpExtension> extensions) override; void SetRtpExtensions(std::vector<RtpExtension> extensions) override;
RtpHeaderExtensionMap GetRtpExtensionMap() const override; RtpHeaderExtensionMap GetRtpExtensionMap() const override;

5
media/engine/fake_webrtc_call.cc
View File

@ -427,11 +427,6 @@ FakeFlexfecReceiveStream::GetConfig() const {
return config_; return config_;
} }
// TODO(brandtr): Implement when the stats have been designed.
webrtc::FlexfecReceiveStream::Stats FakeFlexfecReceiveStream::GetStats() const {
return webrtc::FlexfecReceiveStream::Stats();
}
void FakeFlexfecReceiveStream::OnRtpPacket(const webrtc::RtpPacketReceived&) { void FakeFlexfecReceiveStream::OnRtpPacket(const webrtc::RtpPacketReceived&) {
RTC_DCHECK_NOTREACHED() << "Not implemented."; RTC_DCHECK_NOTREACHED() << "Not implemented.";
} }

2
media/engine/fake_webrtc_call.h
View File

@ -316,8 +316,6 @@ class FakeFlexfecReceiveStream final : public webrtc::FlexfecReceiveStream {
uint32_t remote_ssrc() const { return config_.rtp.remote_ssrc; } uint32_t remote_ssrc() const { return config_.rtp.remote_ssrc; }
private: private:
webrtc::FlexfecReceiveStream::Stats GetStats() const override;
void OnRtpPacket(const webrtc::RtpPacketReceived& packet) override; void OnRtpPacket(const webrtc::RtpPacketReceived& packet) override;
webrtc::FlexfecReceiveStream::Config config_; webrtc::FlexfecReceiveStream::Config config_;