Use backticks not vertical bars to denote variables in comments
Bug: webrtc:12338 Change-Id: I89c8b3a328d04203177522cbdfd9e606fd4bce4c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228246 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34696}
This commit is contained in:
committed by
WebRTC LUCI CQ
parent
603e6e3ffc
commit
cfea2182f8
@ -45,7 +45,7 @@ class AbsoluteCaptureTimeInterpolator {
|
||||
rtc::ArrayView<const uint32_t> csrcs);
|
||||
|
||||
// Returns a received header extension, an interpolated header extension, or
|
||||
// |absl::nullopt| if it's not possible to interpolate a header extension.
|
||||
// `absl::nullopt` if it's not possible to interpolate a header extension.
|
||||
absl::optional<AbsoluteCaptureTime> OnReceivePacket(
|
||||
uint32_t source,
|
||||
uint32_t rtp_timestamp,
|
||||
|
||||
@ -50,7 +50,7 @@ class AbsoluteCaptureTimeSender {
|
||||
static uint32_t GetSource(uint32_t ssrc,
|
||||
rtc::ArrayView<const uint32_t> csrcs);
|
||||
|
||||
// Returns a header extension to be sent, or |absl::nullopt| if the header
|
||||
// Returns a header extension to be sent, or `absl::nullopt` if the header
|
||||
// extension shouldn't be sent.
|
||||
absl::optional<AbsoluteCaptureTime> OnSendPacket(
|
||||
uint32_t source,
|
||||
|
||||
@ -113,7 +113,7 @@ class UlpfecPacketGenerator : public AugmentedPacketGenerator {
|
||||
// Creates a new RtpPacket with FEC payload and RED header. Does this by
|
||||
// creating a new fake media AugmentedPacket, clears the marker bit and adds a
|
||||
// RED header. Finally replaces the payload with the content of
|
||||
// |packet->data|.
|
||||
// `packet->data`.
|
||||
RtpPacketReceived BuildUlpfecRedPacket(
|
||||
const ForwardErrorCorrection::Packet& packet);
|
||||
};
|
||||
|
||||
@ -138,7 +138,7 @@ class FeedbackTester {
|
||||
};
|
||||
|
||||
// The following tests use FeedbackTester that simulates received packets as
|
||||
// specified by the parameters |received_seq[]| and |received_ts[]| (optional).
|
||||
// specified by the parameters `received_seq[]` and `received_ts[]` (optional).
|
||||
// The following is verified in these tests:
|
||||
// - Expected size of serialized packet.
|
||||
// - Expected sequence numbers and receive deltas.
|
||||
|
||||
@ -599,7 +599,7 @@ void RTCPReceiver::HandleReportBlock(const ReportBlock& report_block,
|
||||
//
|
||||
// We can calc RTT if we send a send report and get a report block back.
|
||||
|
||||
// |report_block.source_ssrc()| is the SSRC identifier of the source to
|
||||
// `report_block.source_ssrc()` is the SSRC identifier of the source to
|
||||
// which the information in this reception report block pertains.
|
||||
|
||||
// Filter out all report blocks that are not for us.
|
||||
@ -957,7 +957,7 @@ void RTCPReceiver::HandleTmmbr(const CommonHeader& rtcp_block,
|
||||
entry->tmmbr_item = rtcp::TmmbItem(sender_ssrc, request.bitrate_bps(),
|
||||
request.packet_overhead());
|
||||
// FindOrCreateTmmbrInfo always sets `last_time_received_ms` to
|
||||
// |clock_->TimeInMilliseconds()|.
|
||||
// `clock_->TimeInMilliseconds()`.
|
||||
entry->last_updated_ms = tmmbr_info->last_time_received_ms;
|
||||
|
||||
packet_information->packet_type_flags |= kRtcpTmmbr;
|
||||
|
||||
@ -1335,7 +1335,7 @@ TEST(RtcpReceiverTest,
|
||||
const int64_t kUtcNowUs = 42;
|
||||
|
||||
// The "report_block_timestamp_utc_us" is obtained from the global UTC clock
|
||||
// (not the simulcated |mocks.clock|) and requires a scoped fake clock.
|
||||
// (not the simulcated `mocks.clock`) and requires a scoped fake clock.
|
||||
rtc::ScopedFakeClock fake_clock;
|
||||
fake_clock.SetTime(Timestamp::Micros(kUtcNowUs));
|
||||
|
||||
|
||||
@ -47,7 +47,7 @@ class RtcpTransceiver : public RtcpFeedbackSenderInterface {
|
||||
void Stop(std::function<void()> on_destroyed);
|
||||
|
||||
// Registers observer to be notified about incoming rtcp packets.
|
||||
// Calls to observer will be done on the |config.task_queue|.
|
||||
// Calls to observer will be done on the `config.task_queue`.
|
||||
void AddMediaReceiverRtcpObserver(uint32_t remote_ssrc,
|
||||
MediaReceiverRtcpObserver* observer);
|
||||
// Deregisters the observer. Might return before observer is deregistered.
|
||||
|
||||
@ -431,7 +431,7 @@ std::vector<rtcp::ReportBlock> RtcpTransceiverImpl::CreateReportBlocks(
|
||||
if (!config_.receive_statistics)
|
||||
return {};
|
||||
// TODO(danilchap): Support sending more than
|
||||
// |ReceiverReport::kMaxNumberOfReportBlocks| per compound rtcp packet.
|
||||
// `ReceiverReport::kMaxNumberOfReportBlocks` per compound rtcp packet.
|
||||
std::vector<rtcp::ReportBlock> report_blocks =
|
||||
config_.receive_statistics->RtcpReportBlocks(
|
||||
rtcp::ReceiverReport::kMaxNumberOfReportBlocks);
|
||||
|
||||
@ -693,7 +693,7 @@ static void CopyHeaderAndExtensionsToRtxPacket(const RtpPacketToSend& packet,
|
||||
continue;
|
||||
}
|
||||
|
||||
// Empty extensions should be supported, so not checking |source.empty()|.
|
||||
// Empty extensions should be supported, so not checking `source.empty()`.
|
||||
if (!packet.HasExtension(extension)) {
|
||||
continue;
|
||||
}
|
||||
|
||||
@ -30,12 +30,12 @@ namespace {
|
||||
constexpr size_t kRedForFecHeaderLength = 1;
|
||||
|
||||
// This controls the maximum amount of excess overhead (actual - target)
|
||||
// allowed in order to trigger EncodeFec(), before |params_.max_fec_frames|
|
||||
// allowed in order to trigger EncodeFec(), before `params_.max_fec_frames`
|
||||
// is reached. Overhead here is defined as relative to number of media packets.
|
||||
constexpr int kMaxExcessOverhead = 50; // Q8.
|
||||
|
||||
// This is the minimum number of media packets required (above some protection
|
||||
// level) in order to trigger EncodeFec(), before |params_.max_fec_frames| is
|
||||
// level) in order to trigger EncodeFec(), before `params_.max_fec_frames` is
|
||||
// reached.
|
||||
constexpr size_t kMinMediaPackets = 4;
|
||||
|
||||
@ -146,7 +146,7 @@ void UlpfecGenerator::AddPacketAndGenerateFec(const RtpPacketToSend& packet) {
|
||||
|
||||
auto params = CurrentParams();
|
||||
|
||||
// Produce FEC over at most |params_.max_fec_frames| frames, or as soon as:
|
||||
// Produce FEC over at most `params_.max_fec_frames` frames, or as soon as:
|
||||
// (1) the excess overhead (actual overhead - requested/target overhead) is
|
||||
// less than `kMaxExcessOverhead`, and
|
||||
// (2) at least `min_num_media_packets_` media packets is reached.
|
||||
|
||||
@ -83,7 +83,7 @@ class UlpfecGenerator : public VideoFecGenerator {
|
||||
// Returns true if the excess overhead (actual - target) for the FEC is below
|
||||
// the amount `kMaxExcessOverhead`. This effects the lower protection level
|
||||
// cases and low number of media packets/frame. The target overhead is given
|
||||
// by |params_.fec_rate|, and is only achievable in the limit of large number
|
||||
// by `params_.fec_rate`, and is only achievable in the limit of large number
|
||||
// of media packets.
|
||||
bool ExcessOverheadBelowMax() const;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user