Use backticks not vertical bars to denote variables in comments
Bug: webrtc:12338 Change-Id: I89c8b3a328d04203177522cbdfd9e606fd4bce4c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/228246 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34696}
This commit is contained in:
committed by
WebRTC LUCI CQ
parent
603e6e3ffc
commit
cfea2182f8
@ -25,7 +25,7 @@ struct make_void {
|
||||
|
||||
// webrtc::void_t is an implementation of std::void_t from C++17.
|
||||
//
|
||||
// We use |webrtc::void_t_internal::make_void| as a helper struct to avoid a
|
||||
// We use `webrtc::void_t_internal::make_void` as a helper struct to avoid a
|
||||
// C++14 defect:
|
||||
// http://en.cppreference.com/w/cpp/types/void_t
|
||||
// http://open-std.org/JTC1/SC22/WG21/docs/cwg_defects.html#1558
|
||||
|
||||
@ -31,7 +31,7 @@ class SSLIdentity;
|
||||
// certificate and acts as a text representation of RTCCertificate. Certificates
|
||||
// can be serialized and deserialized to and from this format, which allows for
|
||||
// cloning and storing of certificates to disk. The PEM format is that of
|
||||
// |SSLIdentity::PrivateKeyToPEMString| and |SSLCertificate::ToPEMString|, e.g.
|
||||
// `SSLIdentity::PrivateKeyToPEMString` and `SSLCertificate::ToPEMString`, e.g.
|
||||
// the string representations used by OpenSSL.
|
||||
class RTCCertificatePEM {
|
||||
public:
|
||||
|
||||
@ -51,7 +51,7 @@ scoped_refptr<RTCCertificate> RTCCertificateGenerator::GenerateCertificate(
|
||||
expires_s = std::min(expires_s, kYearInSeconds);
|
||||
// TODO(torbjorng): Stop using `time_t`, its type is unspecified. It it safe
|
||||
// to assume it can hold up to a year's worth of seconds (and more), but
|
||||
// |SSLIdentity::Create| should stop relying on `time_t`.
|
||||
// `SSLIdentity::Create` should stop relying on `time_t`.
|
||||
// See bugs.webrtc.org/5720.
|
||||
time_t cert_lifetime_s = static_cast<time_t>(expires_s);
|
||||
identity = SSLIdentity::Create(kIdentityName, key_params, cert_lifetime_s);
|
||||
|
||||
@ -23,7 +23,7 @@
|
||||
|
||||
namespace rtc {
|
||||
|
||||
// See |RTCCertificateGeneratorInterface::GenerateCertificateAsync|.
|
||||
// See `RTCCertificateGeneratorInterface::GenerateCertificateAsync`.
|
||||
class RTCCertificateGeneratorCallback : public RefCountInterface {
|
||||
public:
|
||||
virtual void OnSuccess(const scoped_refptr<RTCCertificate>& certificate) = 0;
|
||||
|
||||
@ -49,15 +49,15 @@ SSLCertificateStats::~SSLCertificateStats() {}
|
||||
|
||||
std::unique_ptr<SSLCertificateStats> SSLCertificate::GetStats() const {
|
||||
// TODO(bemasc): Move this computation to a helper class that caches these
|
||||
// values to reduce CPU use in |StatsCollector::GetStats|. This will require
|
||||
// adding a fast |SSLCertificate::Equals| to detect certificate changes.
|
||||
// values to reduce CPU use in `StatsCollector::GetStats`. This will require
|
||||
// adding a fast `SSLCertificate::Equals` to detect certificate changes.
|
||||
std::string digest_algorithm;
|
||||
if (!GetSignatureDigestAlgorithm(&digest_algorithm))
|
||||
return nullptr;
|
||||
|
||||
// |SSLFingerprint::Create| can fail if the algorithm returned by
|
||||
// |SSLCertificate::GetSignatureDigestAlgorithm| is not supported by the
|
||||
// implementation of |SSLCertificate::ComputeDigest|. This currently happens
|
||||
// `SSLFingerprint::Create` can fail if the algorithm returned by
|
||||
// `SSLCertificate::GetSignatureDigestAlgorithm` is not supported by the
|
||||
// implementation of `SSLCertificate::ComputeDigest`. This currently happens
|
||||
// with MD5- and SHA-224-signed certificates when linked to libNSS.
|
||||
std::unique_ptr<SSLFingerprint> ssl_fingerprint =
|
||||
SSLFingerprint::Create(digest_algorithm, *this);
|
||||
|
||||
@ -65,12 +65,12 @@ const unsigned char kTestCertSha512[] = {
|
||||
0x35, 0xce, 0x26, 0x58, 0x4a, 0x33, 0x6d, 0xbc, 0xb6};
|
||||
|
||||
// These PEM strings were created by generating an identity with
|
||||
// |SSLIdentity::Create| and invoking |identity->PrivateKeyToPEMString()|,
|
||||
// |identity->PublicKeyToPEMString()| and
|
||||
// |identity->certificate().ToPEMString()|. If the crypto library is updated,
|
||||
// `SSLIdentity::Create` and invoking `identity->PrivateKeyToPEMString()`,
|
||||
// `identity->PublicKeyToPEMString()` and
|
||||
// `identity->certificate().ToPEMString()`. If the crypto library is updated,
|
||||
// and the update changes the string form of the keys, these will have to be
|
||||
// updated too. The fingerprint, fingerprint algorithm and base64 certificate
|
||||
// were created by calling |identity->certificate().GetStats()|.
|
||||
// were created by calling `identity->certificate().GetStats()`.
|
||||
static const char kRSA_PRIVATE_KEY_PEM[] =
|
||||
"-----BEGIN PRIVATE KEY-----\n"
|
||||
"MIICdQIBADANBgkqhkiG9w0BAQEFAASCAl8wggJbAgEAAoGBAMQPqDStRlYeDpkX\n"
|
||||
|
||||
@ -158,7 +158,7 @@ TEST(TimestampAlignerTest, ClipToMonotonous) {
|
||||
|
||||
// Non-monotonic translated timestamps can happen when only for
|
||||
// translated timestamps in the future. Which is tolerated if
|
||||
// |timestamp_aligner.clip_bias_us| is large enough. Instead of
|
||||
// `timestamp_aligner.clip_bias_us` is large enough. Instead of
|
||||
// changing that private member for this test, just add the bias to
|
||||
// `kSystemTimeUs` when calling ClipTimestamp.
|
||||
const int64_t kClipBiasUs = 100000;
|
||||
|
||||
Reference in New Issue
Block a user