zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Merge cpu_features build targets into //system_wrappers."

Browse Source 
This reverts commit 2b242d8fba59ccf67e4c5bcf5a1ea80917a23e1c.

Reason for revert: Breaks downstream project.

Original change's description:
> Merge cpu_features build targets into //system_wrappers.
> 
> Before this CL, functions declared in cpu_features_wrapper.h where
> not defined in the same build target, causing brittle builds that
> might fail at link time if the binary was not depending on
> //system_wrappers (the target with the definitions), violating [1].
> 
> This CL moves everything into //system_wrappers and also moves
> cpu_features_wrapper.h definitions from C to C++ (in order to be able
> to add the definitions to a C++ build target like //system_wrappers).
> 
> [1] - https://webrtc.googlesource.com/src/+/refs/heads/master/style-guide.md#h-cc-pairs
> 
> Bug: None
> Change-Id: I5a0009cddb17206b19f2a71eeba722faacc4bcae
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183380
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#32039}

TBR=mbonadei@webrtc.org,kwiberg@webrtc.org

Change-Id: I4daa7582e55a0343eef72f08ed023c73e0b6456b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183443
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32040}
This commit is contained in:
Mirko Bonadei
2020-09-05 21:18:26 +00:00
committed by Commit Bot
parent 2b242d8fba
commit d156a0d061
16 changed files with 58 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
common_audio/BUILD.gn
View File

@ -54,6 +54,7 @@ rtc_library("common_audio") {
"../rtc_base/system:arch",
"../rtc_base/system:file_wrapper",
"../system_wrappers",
"../system_wrappers:cpu_features_api",
"third_party/ooura:fft_size_256",
]
absl_deps = [ "//third_party/abseil-cpp/absl/types:optional" ]
@ -184,6 +185,7 @@ rtc_library("common_audio_c") {
"../rtc_base:sanitizer",
"../rtc_base/system:arch",
"../system_wrappers",
"../system_wrappers:cpu_features_api",
"third_party/ooura:fft_size_256",
"third_party/spl_sqrt_floor",
]
@ -230,7 +232,7 @@ rtc_library("fir_filter_factory") {
"../rtc_base:checks",
"../rtc_base:rtc_base_approved",
"../rtc_base/system:arch",
"../system_wrappers",
"../system_wrappers:cpu_features_api",
]
if (current_cpu == "x86" || current_cpu == "x64") {
deps += [ ":common_audio_sse2" ]
@ -381,7 +383,7 @@ if (rtc_include_tests) {
"../rtc_base:rtc_base_approved",
"../rtc_base:rtc_base_tests_utils",
"../rtc_base/system:arch",
"../system_wrappers",
"../system_wrappers:cpu_features_api",
"../test:fileutils",
"../test:rtc_expect_death",
"../test:test_main",

2
common_audio/third_party/ooura/BUILD.gn vendored
View File

@ -16,7 +16,7 @@ rtc_library("fft_size_128") {
]
deps = [
"../../../rtc_base/system:arch",
"../../../system_wrappers",
"../../../system_wrappers:cpu_features_api",
]
cflags = []