zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PRESUBMIT: Make BUG= field mandatory.

Browse Source 
Also show a descriptive error message if BUG= field is missing.

BUG=webrtc:6326
NOTRY=True
TESTED=Verified the presubmit error using this very same CL (but with BUG= left empty).

Review-Url: https://codereview.webrtc.org/2322843003
Cr-Commit-Position: refs/heads/master@{#14291}
This commit is contained in:
kjellander
2016-09-19 08:11:16 -07:00
committed by Commit bot
parent 918b554789
commit d1e26a9bc1
1 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
PRESUBMIT.py
View File

@ -448,6 +448,21 @@ def _CheckUnwantedDependencies(input_api, output_api):
warning_descriptions)) warning_descriptions))
return results return results
def _CheckChangeHasBugField(input_api, output_api):
"""Requires that the changelist have a BUG= field.
This check is stricter than the one in depot_tools/presubmit_canned_checks.py
since it fails the presubmit if the BUG= field is missing or doesn't contain
a bug reference.
"""
if input_api.change.BUG:
return []
else:
return [output_api.PresubmitError(
'The BUG=[bug number] field is mandatory. Please create a bug and '
'reference it using either of:\n'
' * https://bugs.webrtc.org - reference it using BUG=webrtc:XXXX\n'
' * https://crbug.com - reference it using BUG=chromium:XXXXXX')]
def _CheckJSONParseErrors(input_api, output_api): def _CheckJSONParseErrors(input_api, output_api):
"""Check that JSON files do not contain syntax errors.""" """Check that JSON files do not contain syntax errors."""
@ -597,8 +612,7 @@ def CheckChangeOnCommit(input_api, output_api):
input_api, output_api)) input_api, output_api))
results.extend(input_api.canned_checks.CheckChangeHasDescription( results.extend(input_api.canned_checks.CheckChangeHasDescription(
input_api, output_api)) input_api, output_api))
results.extend(input_api.canned_checks.CheckChangeHasBugField( results.extend(_CheckChangeHasBugField(input_api, output_api))
input_api, output_api))
results.extend(input_api.canned_checks.CheckChangeHasTestField( results.extend(input_api.canned_checks.CheckChangeHasTestField(
input_api, output_api)) input_api, output_api))
results.extend(input_api.canned_checks.CheckTreeIsOpen( results.extend(input_api.canned_checks.CheckTreeIsOpen(