zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[PCLF] Fix rounding issue in NetworkQualityMetricsReporter

Browse Source 
Bug: b/246095034
Change-Id: Idba4aef450ade431822c9d5e43870281ded55f73
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/277220
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#38235}
This commit is contained in:
Artem Titov
2022-09-28 14:28:13 +02:00
committed by WebRTC LUCI CQ
parent fb409c975f
commit d2cb1f872e
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
test/pc/e2e/network_quality_metrics_reporter.cc
View File

@ -132,7 +132,7 @@ void NetworkQualityMetricsReporter::ReportStats(
Unit::kUnitless, ImprovementDirection::kNeitherIsBetter); Unit::kUnitless, ImprovementDirection::kNeitherIsBetter);
metrics_logger_->LogSingleValueMetric( metrics_logger_->LogSingleValueMetric(
"average_send_rate", GetTestCaseName(network_label), "average_send_rate", GetTestCaseName(network_label),
stats->PacketsSent() >= 2 ? stats->AverageSendRate().kbps() : 0, stats->PacketsSent() >= 2 ? stats->AverageSendRate().kbps<double>() : 0,
Unit::kKilobitsPerSecond, ImprovementDirection::kNeitherIsBetter); Unit::kKilobitsPerSecond, ImprovementDirection::kNeitherIsBetter);
metrics_logger_->LogSingleValueMetric( metrics_logger_->LogSingleValueMetric(
"bytes_discarded_no_receiver", GetTestCaseName(network_label), "bytes_discarded_no_receiver", GetTestCaseName(network_label),
@ -152,7 +152,8 @@ void NetworkQualityMetricsReporter::ReportStats(
ImprovementDirection::kNeitherIsBetter); ImprovementDirection::kNeitherIsBetter);
metrics_logger_->LogSingleValueMetric( metrics_logger_->LogSingleValueMetric(
"average_receive_rate", GetTestCaseName(network_label), "average_receive_rate", GetTestCaseName(network_label),
stats->PacketsReceived() >= 2 ? stats->AverageReceiveRate().kbps() : 0, stats->PacketsReceived() >= 2 ? stats->AverageReceiveRate().kbps<double>()
: 0,
Unit::kKilobitsPerSecond, ImprovementDirection::kNeitherIsBetter); Unit::kKilobitsPerSecond, ImprovementDirection::kNeitherIsBetter);
metrics_logger_->LogSingleValueMetric( metrics_logger_->LogSingleValueMetric(
"sent_packets_loss", GetTestCaseName(network_label), packet_loss, "sent_packets_loss", GetTestCaseName(network_label), packet_loss,