zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prepare to rename RTC_NOTREACHED to RTC_DCHECK_NOTREACHED

Browse Source 
Add implementation of RTC_DCHECK_NOTREACHED equal to the RTC_NOTREACHED.
The new macros will replace the old one when old one's usage will be
removed. The idea of the renaming to provide a clear signal that this
is debug build only macros and will be stripped in the production build.

Bug: webrtc:9065
Change-Id: I4c35d8b03e74a4b3fd1ae75dba2f9c05643101db
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/237802
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35348}
This commit is contained in:
Artem Titov
2021-11-15 16:57:07 +01:00
committed by WebRTC LUCI CQ
parent f5ea3b96cd
commit d3251968d1
263 changed files with 604 additions and 583 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
modules/audio_coding/audio_network_adaptor/controller_manager.cc
View File

@ -265,7 +265,7 @@ std::unique_ptr<ControllerManager> ControllerManagerImpl::Create(
break;
case audio_network_adaptor::config::Controller::kFecControllerRplrBased:
// FecControllerRplrBased has been removed and can't be used anymore.
RTC_NOTREACHED();
RTC_DCHECK_NOTREACHED();
continue;
case audio_network_adaptor::config::Controller::kFrameLengthController:
controller = CreateFrameLengthController(
@ -293,7 +293,7 @@ std::unique_ptr<ControllerManager> ControllerManagerImpl::Create(
encoder_frame_lengths_ms);
break;
default:
RTC_NOTREACHED();
RTC_DCHECK_NOTREACHED();
}
if (controller_config.has_scoring_point()) {
auto& scoring_point = controller_config.scoring_point();
@ -321,7 +321,7 @@ std::unique_ptr<ControllerManager> ControllerManagerImpl::Create(
}
#else
RTC_NOTREACHED();
RTC_DCHECK_NOTREACHED();
return nullptr;
#endif // WEBRTC_ENABLE_PROTOBUF
}

2
modules/audio_coding/audio_network_adaptor/debug_dump_writer.cc
View File

@ -76,7 +76,7 @@ DebugDumpWriterImpl::DebugDumpWriterImpl(FILE* file_handle) {
dump_file_ = FileWrapper(file_handle);
RTC_CHECK(dump_file_.is_open());
#else
RTC_NOTREACHED();
RTC_DCHECK_NOTREACHED();
#endif
}

2
modules/audio_coding/audio_network_adaptor/fec_controller_plr_based.cc
View File

@ -26,7 +26,7 @@ class NullSmoothingFilter final : public SmoothingFilter {
absl::optional<float> GetAverage() override { return last_sample_; }
bool SetTimeConstantMs(int time_constant_ms) override {
RTC_NOTREACHED();
RTC_DCHECK_NOTREACHED();
return false;
}