zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prepare to rename RTC_NOTREACHED to RTC_DCHECK_NOTREACHED

Browse Source 
Add implementation of RTC_DCHECK_NOTREACHED equal to the RTC_NOTREACHED.
The new macros will replace the old one when old one's usage will be
removed. The idea of the renaming to provide a clear signal that this
is debug build only macros and will be stripped in the production build.

Bug: webrtc:9065
Change-Id: I4c35d8b03e74a4b3fd1ae75dba2f9c05643101db
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/237802
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35348}
This commit is contained in:
Artem Titov
2021-11-15 16:57:07 +01:00
committed by WebRTC LUCI CQ
parent f5ea3b96cd
commit d3251968d1
263 changed files with 604 additions and 583 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
modules/audio_device/audio_device_data_observer.cc
View File

@ -110,7 +110,7 @@ class ADMWrapper : public AudioDeviceModule, public AudioTransport {
void* audio_data,
int64_t* elapsed_time_ms,
int64_t* ntp_time_ms) override {
RTC_NOTREACHED();
RTC_DCHECK_NOTREACHED();
}
// Override AudioDeviceModule's RegisterAudioCallback method to remember the

2
modules/audio_device/audio_device_unittest.cc
View File

@ -176,7 +176,7 @@ class FifoAudioStream : public AudioStream {
(static_cast<int32_t>(buffer[2 * i]) + buffer[2 * i + 1]) / 2;
}
} else {
RTC_NOTREACHED() << "Required conversion is not support";
RTC_DCHECK_NOTREACHED() << "Required conversion is not support";
}
fifo_.pop_front();
}

6
modules/audio_device/win/audio_device_core_win.cc
View File

@ -3009,7 +3009,7 @@ DWORD AudioDeviceWindowsCore::DoCaptureThreadPollDMO() {
if (FAILED(hr)) {
_TraceCOMError(hr);
keepRecording = false;
RTC_NOTREACHED();
RTC_DCHECK_NOTREACHED();
break;
}
@ -3021,7 +3021,7 @@ DWORD AudioDeviceWindowsCore::DoCaptureThreadPollDMO() {
if (FAILED(hr)) {
_TraceCOMError(hr);
keepRecording = false;
RTC_NOTREACHED();
RTC_DCHECK_NOTREACHED();
break;
}
@ -3046,7 +3046,7 @@ DWORD AudioDeviceWindowsCore::DoCaptureThreadPollDMO() {
if (FAILED(hr)) {
_TraceCOMError(hr);
keepRecording = false;
RTC_NOTREACHED();
RTC_DCHECK_NOTREACHED();
break;
}

2
modules/audio_device/win/core_audio_utility_win.h
View File

@ -244,7 +244,7 @@ class ScopedHandle {
void Close() {
if (handle_) {
if (!::CloseHandle(handle_)) {
RTC_NOTREACHED();
RTC_DCHECK_NOTREACHED();
}
handle_ = nullptr;
}