zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prepare to rename RTC_NOTREACHED to RTC_DCHECK_NOTREACHED

Browse Source 
Add implementation of RTC_DCHECK_NOTREACHED equal to the RTC_NOTREACHED.
The new macros will replace the old one when old one's usage will be
removed. The idea of the renaming to provide a clear signal that this
is debug build only macros and will be stripped in the production build.

Bug: webrtc:9065
Change-Id: I4c35d8b03e74a4b3fd1ae75dba2f9c05643101db
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/237802
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35348}
This commit is contained in:
Artem Titov
2021-11-15 16:57:07 +01:00
committed by WebRTC LUCI CQ
parent f5ea3b96cd
commit d3251968d1
263 changed files with 604 additions and 583 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
modules/audio_processing/audio_processing_impl.cc
View File

@ -61,7 +61,7 @@ static bool LayoutHasKeyboard(AudioProcessing::ChannelLayout layout) {
return true;
}
RTC_NOTREACHED();
RTC_DCHECK_NOTREACHED();
return false;
}
@ -97,7 +97,7 @@ int SuitableProcessRate(int minimum_rate,
return rate;
}
}
RTC_NOTREACHED();
RTC_DCHECK_NOTREACHED();
return uppermost_native_rate;
}
@ -702,12 +702,12 @@ bool AudioProcessingImpl::PostRuntimeSetting(RuntimeSetting setting) {
return enqueueing_successful;
}
case RuntimeSetting::Type::kNotSpecified:
RTC_NOTREACHED();
RTC_DCHECK_NOTREACHED();
return true;
}
// The language allows the enum to have a non-enumerator
// value. Check that this doesn't happen.
RTC_NOTREACHED();
RTC_DCHECK_NOTREACHED();
return true;
}
@ -878,13 +878,13 @@ void AudioProcessingImpl::HandleCaptureRuntimeSettings() {
break;
}
case RuntimeSetting::Type::kPlayoutAudioDeviceChange:
RTC_NOTREACHED();
RTC_DCHECK_NOTREACHED();
break;
case RuntimeSetting::Type::kCustomRenderProcessingRuntimeSetting:
RTC_NOTREACHED();
RTC_DCHECK_NOTREACHED();
break;
case RuntimeSetting::Type::kNotSpecified:
RTC_NOTREACHED();
RTC_DCHECK_NOTREACHED();
break;
case RuntimeSetting::Type::kCaptureOutputUsed:
bool value;
@ -928,7 +928,7 @@ void AudioProcessingImpl::HandleRenderRuntimeSettings() {
case RuntimeSetting::Type::kCaptureFixedPostGain: // fall-through
case RuntimeSetting::Type::kCaptureOutputUsed: // fall-through
case RuntimeSetting::Type::kNotSpecified:
RTC_NOTREACHED();
RTC_DCHECK_NOTREACHED();
break;
}
}
@ -1592,7 +1592,7 @@ bool AudioProcessingImpl::GetLinearAecOutput(
return true;
}
RTC_LOG(LS_ERROR) << "No linear AEC output available";
RTC_NOTREACHED();
RTC_DCHECK_NOTREACHED();
return false;
}