zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prepare to rename RTC_NOTREACHED to RTC_DCHECK_NOTREACHED

Browse Source 
Add implementation of RTC_DCHECK_NOTREACHED equal to the RTC_NOTREACHED.
The new macros will replace the old one when old one's usage will be
removed. The idea of the renaming to provide a clear signal that this
is debug build only macros and will be stripped in the production build.

Bug: webrtc:9065
Change-Id: I4c35d8b03e74a4b3fd1ae75dba2f9c05643101db
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/237802
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35348}
This commit is contained in:
Artem Titov
2021-11-15 16:57:07 +01:00
committed by WebRTC LUCI CQ
parent f5ea3b96cd
commit d3251968d1
263 changed files with 604 additions and 583 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pc/webrtc_sdp_unittest.cc
View File

@ -966,7 +966,7 @@ static void ReplaceDirection(RtpTransceiverDirection direction,
break;
case RtpTransceiverDirection::kStopped:
default:
RTC_NOTREACHED();
RTC_DCHECK_NOTREACHED();
new_direction = "a=sendrecv";
break;
}
@ -1602,7 +1602,7 @@ class WebRtcSdpTest : public ::testing::Test {
} else if (mline_index == 1) {
content_name = kVideoContentName;
} else {
RTC_NOTREACHED();
RTC_DCHECK_NOTREACHED();
}
TransportInfo transport_info(content_name,
TransportDescription(ufrag, pwd));