zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prepare to rename RTC_NOTREACHED to RTC_DCHECK_NOTREACHED

Browse Source 
Add implementation of RTC_DCHECK_NOTREACHED equal to the RTC_NOTREACHED.
The new macros will replace the old one when old one's usage will be
removed. The idea of the renaming to provide a clear signal that this
is debug build only macros and will be stripped in the production build.

Bug: webrtc:9065
Change-Id: I4c35d8b03e74a4b3fd1ae75dba2f9c05643101db
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/237802
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35348}
This commit is contained in:
Artem Titov
2021-11-15 16:57:07 +01:00
committed by WebRTC LUCI CQ
parent f5ea3b96cd
commit d3251968d1
263 changed files with 604 additions and 583 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
rtc_base/async_tcp_socket.cc
View File

@ -99,7 +99,7 @@ AsyncTCPSocket::State AsyncTCPSocketBase::GetState() const {
case Socket::CS_CONNECTED:
return STATE_CONNECTED;
default:
RTC_NOTREACHED();
RTC_DCHECK_NOTREACHED();
return STATE_CLOSED;
}
}
@ -143,7 +143,7 @@ int AsyncTCPSocketBase::FlushOutBuffer() {
break;
}
if (static_cast<size_t>(res) > view.size()) {
RTC_NOTREACHED();
RTC_DCHECK_NOTREACHED();
res = -1;
break;
}
@ -217,7 +217,7 @@ void AsyncTCPSocketBase::OnReadEvent(Socket* socket) {
if (size > inbuf_.size()) {
RTC_LOG(LS_ERROR) << "input buffer overflow";
RTC_NOTREACHED();
RTC_DCHECK_NOTREACHED();
inbuf_.Clear();
} else {
inbuf_.SetSize(size);
@ -323,7 +323,7 @@ AsyncTcpListenSocket::State AsyncTcpListenSocket::GetState() const {
case Socket::CS_CONNECTING:
return State::kBound;
default:
RTC_NOTREACHED();
RTC_DCHECK_NOTREACHED();
return State::kClosed;
}
}