zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Prepare to rename RTC_NOTREACHED to RTC_DCHECK_NOTREACHED

Browse Source 
Add implementation of RTC_DCHECK_NOTREACHED equal to the RTC_NOTREACHED.
The new macros will replace the old one when old one's usage will be
removed. The idea of the renaming to provide a clear signal that this
is debug build only macros and will be stripped in the production build.

Bug: webrtc:9065
Change-Id: I4c35d8b03e74a4b3fd1ae75dba2f9c05643101db
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/237802
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Artem Titov <titovartem@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35348}
This commit is contained in:
Artem Titov
2021-11-15 16:57:07 +01:00
committed by WebRTC LUCI CQ
parent f5ea3b96cd
commit d3251968d1
263 changed files with 604 additions and 583 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
sdk/android/src/jni/android_network_monitor.cc
View File

@ -104,7 +104,7 @@ static NetworkType GetNetworkTypeFromJava(
if (enum_name == "CONNECTION_NONE") {
return NetworkType::NETWORK_NONE;
}
RTC_NOTREACHED();
RTC_DCHECK_NOTREACHED();
return NetworkType::NETWORK_UNKNOWN;
}
@ -138,7 +138,7 @@ static rtc::AdapterType AdapterTypeFromNetworkType(
// Map it to VPN for now.
return rtc::ADAPTER_TYPE_VPN;
default:
RTC_NOTREACHED() << "Invalid network type " << network_type;
RTC_DCHECK_NOTREACHED() << "Invalid network type " << network_type;
return rtc::ADAPTER_TYPE_UNKNOWN;
}
}

2
sdk/android/src/jni/logging/log_sink.cc
View File

@ -28,7 +28,7 @@ void JNILogSink::OnLogMessage(const std::string& msg,
}
void JNILogSink::OnLogMessage(const std::string& msg) {
RTC_NOTREACHED();
RTC_DCHECK_NOTREACHED();
}
} // namespace jni

2
sdk/android/src/jni/pc/peer_connection.cc
View File

@ -117,7 +117,7 @@ SdpSemantics JavaToNativeSdpSemantics(JNIEnv* jni,
if (enum_name == "UNIFIED_PLAN")
return SdpSemantics::kUnifiedPlan;
RTC_NOTREACHED();
RTC_DCHECK_NOTREACHED();
return SdpSemantics::kPlanB;
}

2
sdk/android/src/jni/pc/rtc_stats_collector_callback_wrapper.cc
View File

@ -112,7 +112,7 @@ ScopedJavaLocalRef<jobject> MemberToJava(
NativeToJavaDouble(env, entry.second));
});
}
RTC_NOTREACHED();
RTC_DCHECK_NOTREACHED();
return nullptr;
}