zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Control rtt_mult addition cap via experiment.

Browse Source 
Bug: webrtc:10717
Change-Id: I68f7d8216e1a1611e692dd82ba96890cad98c7de
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/140284
Commit-Queue: Michael Horowitz <mhoro@webrtc.org>
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28191}
This commit is contained in:
“Michael
2019-06-07 03:55:01 -05:00
committed by Commit Bot
parent 944dacec25
commit d3a4ebe332
6 changed files with 64 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
rtc_base/experiments/rtt_mult_experiment_unittest.cc
View File

@ -20,33 +20,43 @@ TEST(RttMultExperimentTest, RttMultDisabledByDefault) {
}
TEST(RttMultExperimentTest, RttMultEnabledByFieldTrial) {
webrtc::test::ScopedFieldTrials field_trials("WebRTC-RttMult/Enabled-0.25/");
webrtc::test::ScopedFieldTrials field_trials(
"WebRTC-RttMult/Enabled-0.60,100.0/");
EXPECT_TRUE(RttMultExperiment::RttMultEnabled());
}
TEST(RttMultExperimentTest, RttMultTestValue) {
webrtc::test::ScopedFieldTrials field_trials("WebRTC-RttMult/Enabled-0.25/");
EXPECT_EQ(0.25, RttMultExperiment::GetRttMultValue());
webrtc::test::ScopedFieldTrials field_trials(
"WebRTC-RttMult/Enabled-0.60,100.0/");
EXPECT_EQ(0.6f, RttMultExperiment::GetRttMultValue()->rtt_mult_setting);
EXPECT_EQ(100.0f, RttMultExperiment::GetRttMultValue()->rtt_mult_add_cap_ms);
}
TEST(RttMultExperimentTest, RttMultTestMalformedEnabled) {
webrtc::test::ScopedFieldTrials field_trials("WebRTC-RttMult/Enable-0.25/");
webrtc::test::ScopedFieldTrials field_trials(
"WebRTC-RttMult/Enable-0.60,100.0/");
EXPECT_FALSE(RttMultExperiment::RttMultEnabled());
EXPECT_FALSE(RttMultExperiment::GetRttMultValue());
}
TEST(RttMultExperimentTest, RttMultTestValueOutOfBoundsPositive) {
webrtc::test::ScopedFieldTrials field_trials("WebRTC-RttMult/Enabled-1.5/");
EXPECT_EQ(1.0, RttMultExperiment::GetRttMultValue());
webrtc::test::ScopedFieldTrials field_trials(
"WebRTC-RttMult/Enabled-1.5,2100.0/");
EXPECT_EQ(1.0f, RttMultExperiment::GetRttMultValue()->rtt_mult_setting);
EXPECT_EQ(2000.0f, RttMultExperiment::GetRttMultValue()->rtt_mult_add_cap_ms);
}
TEST(RttMultExperimentTest, RttMultTestValueOutOfBoundsNegative) {
webrtc::test::ScopedFieldTrials field_trials("WebRTC-RttMult/Enabled--0.5/");
EXPECT_EQ(0.0, RttMultExperiment::GetRttMultValue());
webrtc::test::ScopedFieldTrials field_trials(
"WebRTC-RttMult/Enabled--0.5,-100.0/");
EXPECT_EQ(0.0f, RttMultExperiment::GetRttMultValue()->rtt_mult_setting);
EXPECT_EQ(0.0f, RttMultExperiment::GetRttMultValue()->rtt_mult_add_cap_ms);
}
TEST(RttMultExperimentTest, RttMultTestMalformedValue) {
webrtc::test::ScopedFieldTrials field_trials("WebRTC-RttMult/Enabled-0.2a5/");
EXPECT_NE(0.25, RttMultExperiment::GetRttMultValue());
webrtc::test::ScopedFieldTrials field_trials(
"WebRTC-RttMult/Enabled-0.25,10a0.0/");
EXPECT_NE(100.0f, RttMultExperiment::GetRttMultValue()->rtt_mult_add_cap_ms);
}
} // namespace webrtc