zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

RTC_EXPORT missing symbols for Chromium's component build.

Browse Source 
This CL adds a dependecy on rtc_base/system:rtc_export to rtc_event but
only when built as part of Chromium (since rtc::Event should not be
used outside of WebRTC).

It also adds other missing RTC_EXPORTS.

Bug: webrtc:9419
Change-Id: Ib338004a5404a6b3c7929e146c29ad42572632cc
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159692
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#29781}
This commit is contained in:
Mirko Bonadei
2019-11-12 20:11:48 +01:00
committed by Commit Bot
parent f47c2ab889
commit d4002a733d
5 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
api/task_queue/BUILD.gn
View File

@ -22,6 +22,7 @@ rtc_library("task_queue") {
deps = [ deps = [
"../../rtc_base:checks", "../../rtc_base:checks",
"../../rtc_base:macromagic", "../../rtc_base:macromagic",
"../../rtc_base/system:rtc_export",
"//third_party/abseil-cpp/absl/base:config", "//third_party/abseil-cpp/absl/base:config",
"//third_party/abseil-cpp/absl/base:core_headers", "//third_party/abseil-cpp/absl/base:core_headers",
"//third_party/abseil-cpp/absl/strings", "//third_party/abseil-cpp/absl/strings",

3
api/task_queue/task_queue_base.h
View File

@ -13,6 +13,7 @@
#include <memory> #include <memory>
#include "api/task_queue/queued_task.h" #include "api/task_queue/queued_task.h"
#include "rtc_base/system/rtc_export.h"
#include "rtc_base/thread_annotations.h" #include "rtc_base/thread_annotations.h"
namespace webrtc { namespace webrtc {
@ -21,7 +22,7 @@ namespace webrtc {
// in FIFO order and that tasks never overlap. Tasks may always execute on the // in FIFO order and that tasks never overlap. Tasks may always execute on the
// same worker thread and they may not. To DCHECK that tasks are executing on a // same worker thread and they may not. To DCHECK that tasks are executing on a
// known task queue, use IsCurrent(). // known task queue, use IsCurrent().
class RTC_LOCKABLE TaskQueueBase { class RTC_LOCKABLE RTC_EXPORT TaskQueueBase {
public: public:
// Starts destruction of the task queue. // Starts destruction of the task queue.
// On return ensures no task are running and no new tasks are able to start // On return ensures no task are running and no new tasks are able to start

2
api/video/video_frame.h
View File

@ -29,7 +29,7 @@ namespace webrtc {
class RTC_EXPORT VideoFrame { class RTC_EXPORT VideoFrame {
public: public:
struct UpdateRect { struct RTC_EXPORT UpdateRect {
int offset_x; int offset_x;
int offset_y; int offset_y;
int width; int width;

4
modules/audio_processing/include/audio_processing.h
View File

@ -246,9 +246,9 @@ class RTC_EXPORT AudioProcessing : public rtc::RefCountInterface {
// top-level processing effects. Use during processing may cause undesired // top-level processing effects. Use during processing may cause undesired
// submodule resets, affecting the audio quality. Use the RuntimeSetting // submodule resets, affecting the audio quality. Use the RuntimeSetting
// construct for runtime configuration. // construct for runtime configuration.
struct Config { struct RTC_EXPORT Config {
// Sets the properties of the audio processing pipeline. // Sets the properties of the audio processing pipeline.
struct Pipeline { struct RTC_EXPORT Pipeline {
Pipeline(); Pipeline();
// Maximum allowed processing rate used internally. May only be set to // Maximum allowed processing rate used internally. May only be set to

1
rtc_base/BUILD.gn
View File

@ -228,6 +228,7 @@ rtc_library("rtc_event") {
] ]
deps = [ deps = [
":checks", ":checks",
"system:rtc_export", # Only Chromium's rtc::Event use RTC_EXPORT.
"//base", # Dependency on chromium's waitable_event. "//base", # Dependency on chromium's waitable_event.
] ]
} else { } else {