zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Enable Video-QualityScaling experiment by default"

Browse Source 
This reverts commit 066b5b6ed7069d78e17b8ad6fb8c82546b31acea.

Reason for revert: Regressions on iOS testbots.

Original change's description:
> Enable Video-QualityScaling experiment by default
>
> Bug: webrtc:12401
> Change-Id: Iebf3130e785892bb9fddf1012bc46027a21085a4
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/204000
> Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
> Reviewed-by: Åsa Persson <asapersson@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#33091}

TBR=ilnik@webrtc.org,asapersson@webrtc.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: webrtc:12401
Change-Id: I489b805c7741b63c22c16cfce03347179a3e2602
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/205001
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33123}
This commit is contained in:
Ilya Nikolaevskiy
2021-02-01 12:01:06 +00:00
committed by Commit Bot
parent 3faea70d1a
commit d6604df27f
4 changed files with 9 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
rtc_base/experiments/quality_scaling_experiment_unittest.cc
View File

@ -38,9 +38,9 @@ void ExpectEqualConfig(QualityScalingExperiment::Config a,
}
} // namespace
TEST(QualityScalingExperimentTest, DefaultEnabledWithoutFieldTrial) {
TEST(QualityScalingExperimentTest, DisabledWithoutFieldTrial) {
webrtc::test::ScopedFieldTrials field_trials("");
EXPECT_TRUE(QualityScalingExperiment::Enabled());
EXPECT_FALSE(QualityScalingExperiment::Enabled());
}
TEST(QualityScalingExperimentTest, EnabledWithFieldTrial) {
@ -59,10 +59,9 @@ TEST(QualityScalingExperimentTest, ParseSettings) {
ExpectEqualSettings(kExpected, *settings);
}
TEST(QualityScalingExperimentTest, ParseSettingsUsesDefaultsWithoutFieldTrial) {
TEST(QualityScalingExperimentTest, ParseSettingsFailsWithoutFieldTrial) {
webrtc::test::ScopedFieldTrials field_trials("");
// Uses some default hard coded values.
EXPECT_TRUE(QualityScalingExperiment::ParseSettings());
EXPECT_FALSE(QualityScalingExperiment::ParseSettings());
}
TEST(QualityScalingExperimentTest, ParseSettingsFailsWithInvalidFieldTrial) {