Use backticks not vertical bars to denote variables in comments for /sdk
Bug: webrtc:12338 Change-Id: Ifaad29ccb63b0f2f3aeefb77dae061ebc7f87e6c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227024 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/master@{#34561}
This commit is contained in:
committed by
WebRTC LUCI CQ
parent
f0671921a1
commit
d7ac581045
@ -18,7 +18,7 @@
|
||||
#include "sdk/android/native_api/jni/java_types.h"
|
||||
#include "sdk/android/native_api/jni/scoped_java_ref.h"
|
||||
|
||||
// Abort the process if |jni| has a Java exception pending. This macros uses the
|
||||
// Abort the process if `jni` has a Java exception pending. This macros uses the
|
||||
// comma operator to execute ExceptionDescribe and ExceptionClear ignoring their
|
||||
// return values and sending "" to the error stream.
|
||||
#define CHECK_EXCEPTION(jni) \
|
||||
|
||||
@ -30,7 +30,7 @@
|
||||
#include "rtc_base/checks.h"
|
||||
#include "sdk/android/native_api/jni/scoped_java_ref.h"
|
||||
|
||||
// Abort the process if |jni| has a Java exception pending.
|
||||
// Abort the process if `jni` has a Java exception pending.
|
||||
// This macros uses the comma operator to execute ExceptionDescribe
|
||||
// and ExceptionClear ignoring their return values and sending ""
|
||||
// to the error stream.
|
||||
@ -110,7 +110,7 @@ class Iterable {
|
||||
RTC_DISALLOW_COPY_AND_ASSIGN(Iterable);
|
||||
};
|
||||
|
||||
// Returns true if |obj| == null in Java.
|
||||
// Returns true if `obj` == null in Java.
|
||||
bool IsNull(JNIEnv* jni, const JavaRef<jobject>& obj);
|
||||
|
||||
// Returns the name of a Java enum.
|
||||
@ -319,7 +319,7 @@ ScopedJavaLocalRef<jobject> NativeToJavaStringMap(JNIEnv* env,
|
||||
return builder.GetJavaMap();
|
||||
}
|
||||
|
||||
// Return a |jlong| that will correctly convert back to |ptr|. This is needed
|
||||
// Return a `jlong` that will correctly convert back to `ptr`. This is needed
|
||||
// because the alternative (of silently passing a 32-bit pointer to a vararg
|
||||
// function expecting a 64-bit param) picks up garbage in the high 32 bits.
|
||||
jlong NativeToJavaPointer(void* ptr);
|
||||
|
||||
@ -74,7 +74,7 @@ class JavaRef : public JavaRef<jobject> {
|
||||
template <typename T>
|
||||
class JavaParamRef : public JavaRef<T> {
|
||||
public:
|
||||
// Assumes that |obj| is a parameter passed to a JNI method from Java.
|
||||
// Assumes that `obj` is a parameter passed to a JNI method from Java.
|
||||
// Does not assume ownership as parameters should not be deleted.
|
||||
explicit JavaParamRef(T obj) : JavaRef<T>(obj) {}
|
||||
JavaParamRef(JNIEnv*, T obj) : JavaRef<T>(obj) {}
|
||||
@ -112,7 +112,7 @@ class ScopedJavaLocalRef : public JavaRef<T> {
|
||||
Reset(other.obj(), OwnershipPolicy::RETAIN);
|
||||
}
|
||||
|
||||
// Assumes that |obj| is a reference to a Java object and takes
|
||||
// Assumes that `obj` is a reference to a Java object and takes
|
||||
// ownership of this reference. This should preferably not be used
|
||||
// outside of JNI helper functions.
|
||||
ScopedJavaLocalRef(JNIEnv* env, T obj) : JavaRef<T>(obj), env_(env) {}
|
||||
|
||||
@ -20,7 +20,7 @@
|
||||
|
||||
namespace webrtc {
|
||||
|
||||
// Creates java PeerConnectionFactory with specified |pcf|.
|
||||
// Creates java PeerConnectionFactory with specified `pcf`.
|
||||
jobject NativeToJavaPeerConnectionFactory(
|
||||
JNIEnv* jni,
|
||||
rtc::scoped_refptr<webrtc::PeerConnectionFactoryInterface> pcf,
|
||||
|
||||
@ -99,7 +99,7 @@ ABSL_CONST_INIT GlobalMutex g_signal_handler_lock(absl::kConstInit);
|
||||
SignalHandlerOutputState* volatile g_signal_handler_output_state;
|
||||
|
||||
// This function is called iteratively for each stack trace element and stores
|
||||
// the element in the array from |unwind_output_state|.
|
||||
// the element in the array from `unwind_output_state`.
|
||||
_Unwind_Reason_Code UnwindBacktrace(struct _Unwind_Context* unwind_context,
|
||||
void* unwind_output_state) {
|
||||
SignalHandlerOutputState* const output_state =
|
||||
@ -136,7 +136,7 @@ void SignalHandler(int signum, siginfo_t* info, void* ptr) {
|
||||
|
||||
// Temporarily change the signal handler to a function that records a raw stack
|
||||
// trace and interrupt the given tid. This function will block until the output
|
||||
// thread stack trace has been stored in |params|. The return value is an error
|
||||
// thread stack trace has been stored in `params`. The return value is an error
|
||||
// string on failure and null on success.
|
||||
const char* CaptureRawStacktrace(int pid,
|
||||
int tid,
|
||||
@ -206,8 +206,8 @@ std::vector<StackTraceElement> FormatStackTrace(
|
||||
std::vector<StackTraceElement> GetStackTrace(int tid) {
|
||||
// Only a thread itself can unwind its stack, so we will interrupt the given
|
||||
// tid with a custom signal handler in order to unwind its stack. The stack
|
||||
// will be recorded to |params| through the use of the global pointer
|
||||
// |g_signal_handler_param|.
|
||||
// will be recorded to `params` through the use of the global pointer
|
||||
// `g_signal_handler_param`.
|
||||
SignalHandlerOutputState params;
|
||||
|
||||
const char* error_string = CaptureRawStacktrace(getpid(), tid, ¶ms);
|
||||
|
||||
Reference in New Issue
Block a user