zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

RateControlSettings: add option to set max QP for libvpx vp8.

Browse Source 
Bug: none
Change-Id: Ia662068fe179faebc1df0aaa7f37b6e989b6525f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/135569
Reviewed-by: Erik Språng <sprang@webrtc.org>
Commit-Queue: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27888}
This commit is contained in:
Åsa Persson
2019-05-08 14:44:12 +02:00
committed by Commit Bot
parent ea5cbb5d1a
commit d7dd49ff3d
4 changed files with 30 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
rtc_base/experiments/rate_control_settings_unittest.cc
View File

@ -65,6 +65,20 @@ TEST(RateControlSettingsTest, AlrProbing) {
EXPECT_TRUE(RateControlSettings::ParseFromFieldTrials().UseAlrProbing());
}
TEST(RateControlSettingsTest, LibvpxVp8QpMax) {
EXPECT_FALSE(RateControlSettings::ParseFromFieldTrials().LibvpxVp8QpMax());
test::ScopedFieldTrials field_trials(
"WebRTC-VideoRateControl/vp8_qp_max:50/");
EXPECT_EQ(RateControlSettings::ParseFromFieldTrials().LibvpxVp8QpMax(), 50);
}
TEST(RateControlSettingsTest, DoesNotGetTooLargeLibvpxVp8QpMaxValue) {
test::ScopedFieldTrials field_trials(
"WebRTC-VideoRateControl/vp8_qp_max:70/");
EXPECT_FALSE(RateControlSettings::ParseFromFieldTrials().LibvpxVp8QpMax());
}
TEST(RateControlSettingsTest, LibvpxTrustedRateController) {
const RateControlSettings settings_before =
RateControlSettings::ParseFromFieldTrials();