zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

iOS: Add improved BWE field trial.

Browse Source 
BUG=webrtc:6664
NOTRY=True

Review-Url: https://codereview.webrtc.org/2482593002
Cr-Commit-Position: refs/heads/master@{#14958}
This commit is contained in:
tkchin
2016-11-07 11:38:53 -08:00
committed by Commit bot
parent ec7b009752
commit d83bf06167
3 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
webrtc/examples/objc/AppRTCMobile/ios/ARDAppDelegate.m
View File

@ -25,7 +25,7 @@
- (BOOL)application:(UIApplication *)application - (BOOL)application:(UIApplication *)application
didFinishLaunchingWithOptions:(NSDictionary *)launchOptions { didFinishLaunchingWithOptions:(NSDictionary *)launchOptions {
RTCInitFieldTrials(RTCFieldTrialOptionsSendSideBwe); RTCInitFieldTrials(RTCFieldTrialOptionsImprovedBitrateEstimate);
RTCInitializeSSL(); RTCInitializeSSL();
RTCSetupInternalTracer(); RTCSetupInternalTracer();
_window = [[UIWindow alloc] initWithFrame:[[UIScreen mainScreen] bounds]]; _window = [[UIWindow alloc] initWithFrame:[[UIScreen mainScreen] bounds]];

8
webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm
View File

@ -16,12 +16,20 @@
#include "webrtc/system_wrappers/include/field_trial_default.h" #include "webrtc/system_wrappers/include/field_trial_default.h"
static NSString * const kRTCEnableImprovedBitrateEstimateString =
@"WebRTC-ImprovedBitrateEstimate/Enabled/";
static std::unique_ptr<char[]> gFieldTrialInitString; static std::unique_ptr<char[]> gFieldTrialInitString;
void RTCInitFieldTrials(RTCFieldTrialOptions options) { void RTCInitFieldTrials(RTCFieldTrialOptions options) {
NSMutableString *fieldTrialInitString = [NSMutableString string]; NSMutableString *fieldTrialInitString = [NSMutableString string];
size_t len = fieldTrialInitString.length + 1; size_t len = fieldTrialInitString.length + 1;
gFieldTrialInitString.reset(new char[len]); gFieldTrialInitString.reset(new char[len]);
if (options & RTCFieldTrialOptionsImprovedBitrateEstimate) {
[fieldTrialInitString appendString:kRTCEnableImprovedBitrateEstimateString];
}
if (![fieldTrialInitString getCString:gFieldTrialInitString.get() if (![fieldTrialInitString getCString:gFieldTrialInitString.get()
maxLength:len maxLength:len
encoding:NSUTF8StringEncoding]) { encoding:NSUTF8StringEncoding]) {

2
webrtc/sdk/objc/Framework/Headers/WebRTC/RTCFieldTrials.h
View File

@ -14,7 +14,7 @@
typedef NS_OPTIONS(NSUInteger, RTCFieldTrialOptions) { typedef NS_OPTIONS(NSUInteger, RTCFieldTrialOptions) {
RTCFieldTrialOptionsNone = 0, RTCFieldTrialOptionsNone = 0,
RTCFieldTrialOptionsSendSideBwe = 1 << 0, RTCFieldTrialOptionsImprovedBitrateEstimate = 1 << 0,
}; };
/** Must be called before any other call into WebRTC. See: /** Must be called before any other call into WebRTC. See: