zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete unimplemented methods from the NetEq interface.

Browse Source 
Bug: None
Change-Id: I51949a096c445813acc6649676e32c575732ef40
Reviewed-on: https://webrtc-review.googlesource.com/95643
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24469}
This commit is contained in:
Niels Möller
2018-08-27 12:44:08 +02:00
committed by Commit Bot
parent 0e468e741c
commit d941c09bc0
3 changed files with 1 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
modules/audio_coding/neteq/include/neteq.h
View File

@ -96,7 +96,7 @@ class NetEq {
bool for_test_no_time_stretching = false; // Use only for testing.
};
enum ReturnCodes { kOK = 0, kFail = -1, kNotImplemented = -2 };
enum ReturnCodes { kOK = 0, kFail = -1 };
// Creates a new NetEq object, with parameters set in |config|. The |config|
// object will only have to be valid for the duration of the call to this
@ -180,9 +180,6 @@ class NetEq {
// the |max_delay_ms| value in the NetEq::Config struct.
virtual bool SetMaximumDelay(int delay_ms) = 0;
// Not implemented.
virtual int SetTargetDelay() = 0;
// Returns the current target delay in ms. This includes any extra delay
// requested through SetMinimumDelay.
virtual int TargetDelayMs() const = 0;
@ -235,12 +232,6 @@ class NetEq {
virtual absl::optional<SdpAudioFormat> GetDecoderFormat(
int payload_type) const = 0;
// Not implemented.
virtual int SetTargetNumberOfChannels() = 0;
// Not implemented.
virtual int SetTargetSampleRate() = 0;
// Flushes both the packet buffer and the sync buffer.
virtual void FlushBuffers() = 0;

12
modules/audio_coding/neteq/neteq_impl.cc
View File

@ -307,10 +307,6 @@ bool NetEqImpl::SetMaximumDelay(int delay_ms) {
return false;
}
int NetEqImpl::SetTargetDelay() {
return kNotImplemented;
}
int NetEqImpl::TargetDelayMs() const {
rtc::CritScope lock(&crit_sect_);
RTC_DCHECK(delay_manager_.get());
@ -448,14 +444,6 @@ absl::optional<SdpAudioFormat> NetEqImpl::GetDecoderFormat(
return di->GetFormat();
}
int NetEqImpl::SetTargetNumberOfChannels() {
return kNotImplemented;
}
int NetEqImpl::SetTargetSampleRate() {
return kNotImplemented;
}
void NetEqImpl::FlushBuffers() {
rtc::CritScope lock(&crit_sect_);
RTC_LOG(LS_VERBOSE) << "FlushBuffers";

6
modules/audio_coding/neteq/neteq_impl.h
View File

@ -157,8 +157,6 @@ class NetEqImpl : public webrtc::NetEq {
bool SetMaximumDelay(int delay_ms) override;
int SetTargetDelay() override;
int TargetDelayMs() const override;
int CurrentDelayMs() const override;
@ -194,10 +192,6 @@ class NetEqImpl : public webrtc::NetEq {
absl::optional<SdpAudioFormat> GetDecoderFormat(
int payload_type) const override;
int SetTargetNumberOfChannels() override;
int SetTargetSampleRate() override;
// Flushes both the packet buffer and the sync buffer.
void FlushBuffers() override;