zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert of Remove ignored return code from modules. (patchset #3 id:40001 of https://codereview.webrtc.org/1703833002/ )

Browse Source 
Reason for revert:
Breaks Chromium.

Original issue's description:
> Remove ignored return code from modules.
>
> ModuleProcessImpl doesn't act on return codes and having them around is
> confusing (it's unclear what an error return code here would do even).
>
> BUG=
> R=tommi@webrtc.org
>
> Committed: f14c47a58c

TBR=tommi@webrtc.org,pbos@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.webrtc.org/1736663004

Cr-Commit-Position: refs/heads/master@{#11761}
This commit is contained in:
torbjorng
2016-02-25 04:34:03 -08:00
committed by Commit bot
parent 91c5b5650c
commit da33a8a2a2
66 changed files with 192 additions and 140 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
webrtc/modules/bitrate_controller/bitrate_controller_impl.cc
View File

@ -162,15 +162,16 @@ int64_t BitrateControllerImpl::TimeUntilNextProcess() {
kBitrateControllerUpdateIntervalMs - time_since_update_ms, 0);
}
void BitrateControllerImpl::Process() {
int32_t BitrateControllerImpl::Process() {
if (TimeUntilNextProcess() > 0)
return;
return 0;
{
rtc::CritScope cs(&critsect_);
bandwidth_estimation_.UpdateEstimate(clock_->TimeInMilliseconds());
}
MaybeTriggerOnNetworkChanged();
last_bitrate_update_ms_ = clock_->TimeInMilliseconds();
return 0;
}
void BitrateControllerImpl::OnReceivedRtcpReceiverReport(