zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert of Remove ignored return code from modules. (patchset #3 id:40001 of https://codereview.webrtc.org/1703833002/ )

Browse Source 
Reason for revert:
Breaks Chromium.

Original issue's description:
> Remove ignored return code from modules.
>
> ModuleProcessImpl doesn't act on return codes and having them around is
> confusing (it's unclear what an error return code here would do even).
>
> BUG=
> R=tommi@webrtc.org
>
> Committed: f14c47a58c

TBR=tommi@webrtc.org,pbos@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.webrtc.org/1736663004

Cr-Commit-Position: refs/heads/master@{#11761}
This commit is contained in:
torbjorng
2016-02-25 04:34:03 -08:00
committed by Commit bot
parent 91c5b5650c
commit da33a8a2a2
66 changed files with 192 additions and 140 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
webrtc/modules/video_coding/video_coding_impl.cc
View File

@ -94,9 +94,12 @@ class VideoCodingModuleImpl : public VideoCodingModule {
return VCM_MIN(sender_time, receiver_time);
}
void Process() override {
sender_.Process();
receiver_.Process();
int32_t Process() override {
int32_t sender_return = sender_.Process();
int32_t receiver_return = receiver_.Process();
if (sender_return != VCM_OK)
return sender_return;
return receiver_return;
}
int32_t RegisterSendCodec(const VideoCodec* sendCodec,