From dbbf41308593afef530c83e73744064eb4ff50a0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Erik=20Spr=C3=A5ng?= Date: Fri, 18 Oct 2019 10:34:25 +0200 Subject: [PATCH] Fix use of unitialized value in test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Local media SSRC is mandatory, but let's give it a default value to make tests less brittle. Bug: chromium:1015256 Change-Id: If7f6505482d90651bc58d9b358290c4d43487f4e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157421 Commit-Queue: Erik Språng Reviewed-by: Danil Chapovalov Reviewed-by: Ilya Nikolaevskiy Cr-Commit-Position: refs/heads/master@{#29534} --- modules/rtp_rtcp/include/rtp_rtcp.h | 2 +- test/fuzzers/rtcp_receiver_fuzzer.cc | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/modules/rtp_rtcp/include/rtp_rtcp.h b/modules/rtp_rtcp/include/rtp_rtcp.h index b877045d81..adce9649d7 100644 --- a/modules/rtp_rtcp/include/rtp_rtcp.h +++ b/modules/rtp_rtcp/include/rtp_rtcp.h @@ -123,7 +123,7 @@ class RtpRtcp : public Module, public RtcpFeedbackSenderInterface { // SSRCs for media and retransmission, respectively. // FlexFec SSRC is fetched from |flexfec_sender|. - uint32_t local_media_ssrc; + uint32_t local_media_ssrc = 0; absl::optional rtx_send_ssrc; private: diff --git a/test/fuzzers/rtcp_receiver_fuzzer.cc b/test/fuzzers/rtcp_receiver_fuzzer.cc index 46bb9eb68b..38213c3a6e 100644 --- a/test/fuzzers/rtcp_receiver_fuzzer.cc +++ b/test/fuzzers/rtcp_receiver_fuzzer.cc @@ -43,6 +43,7 @@ void FuzzOneInput(const uint8_t* data, size_t size) { RtpRtcp::Configuration config; config.clock = &clock; config.rtcp_report_interval_ms = kRtcpIntervalMs; + config.local_media_ssrc = 1; RTCPReceiver receiver(config, &rtp_rtcp_module);