From dcfa938f9e768d463d3e336f4d014027504267dd Mon Sep 17 00:00:00 2001
From: Joachim Reiersen <joachimr@fb.com>
Date: Thu, 26 Jul 2018 12:58:20 -0700
Subject: [PATCH] Add framesRendered to StatsReport

Bug: webrtc:9568
Change-Id: I6976f4c48b67f6a81f57260a91966debbef38eb4
Reviewed-on: https://webrtc-review.googlesource.com/90840
Reviewed-by: Steve Anton <steveanton@webrtc.org>
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24121}
---
 api/statstypes.cc             | 2 ++
 api/statstypes.h              | 1 +
 pc/statscollector.cc          | 2 +-
 pc/statscollector_unittest.cc | 6 +++++-
 4 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/api/statstypes.cc b/api/statstypes.cc
index ceba28d20f..ef0eac9d41 100644
--- a/api/statstypes.cc
+++ b/api/statstypes.cc
@@ -400,6 +400,8 @@ const char* StatsReport::Value::display_name() const {
       return "datachannelid";
     case kStatsValueNameFramesDecoded:
       return "framesDecoded";
+    case kStatsValueNameFramesRendered:
+      return "framesRendered";
     case kStatsValueNameFramesEncoded:
       return "framesEncoded";
     case kStatsValueNameJitterBufferDelay:
diff --git a/api/statstypes.h b/api/statstypes.h
index 857b1afaa7..e249d00293 100644
--- a/api/statstypes.h
+++ b/api/statstypes.h
@@ -107,6 +107,7 @@ class StatsReport {
     kStatsValueNameConcealmentEvents,
     kStatsValueNameDataChannelId,
     kStatsValueNameFramesDecoded,
+    kStatsValueNameFramesRendered,
     kStatsValueNameFramesEncoded,
     kStatsValueNameJitterBufferDelay,
     kStatsValueNameMediaType,
diff --git a/pc/statscollector.cc b/pc/statscollector.cc
index e42244a0c0..cf03ae55d4 100644
--- a/pc/statscollector.cc
+++ b/pc/statscollector.cc
@@ -275,7 +275,7 @@ void ExtractStats(const cricket::VideoReceiverInfo& info, StatsReport* report) {
       {StatsReport::kStatsValueNameRenderDelayMs, info.render_delay_ms},
       {StatsReport::kStatsValueNameTargetDelayMs, info.target_delay_ms},
       {StatsReport::kStatsValueNameFramesDecoded, info.frames_decoded},
-  };
+      {StatsReport::kStatsValueNameFramesRendered, info.frames_rendered}};
 
   for (const auto& i : ints)
     report->AddInt(i.name, i.value);
diff --git a/pc/statscollector_unittest.cc b/pc/statscollector_unittest.cc
index 2a2a2dc9b6..91d4859283 100644
--- a/pc/statscollector_unittest.cc
+++ b/pc/statscollector_unittest.cc
@@ -1741,7 +1741,8 @@ TEST_P(StatsCollectorTrackTest, VerifyVideoReceiveSsrcStatsNew) {
   VideoReceiverInfo video_receiver_info;
   video_receiver_info.add_ssrc(1234);
   video_receiver_info.frames_decoded = 10;
-  video_receiver_info.qp_sum = 11;
+  video_receiver_info.frames_rendered = 11;
+  video_receiver_info.qp_sum = 12;
   VideoMediaInfo video_info;
   video_info.receivers.push_back(video_receiver_info);
 
@@ -1755,6 +1756,9 @@ TEST_P(StatsCollectorTrackTest, VerifyVideoReceiveSsrcStatsNew) {
   EXPECT_EQ(rtc::ToString(video_receiver_info.frames_decoded),
             ExtractSsrcStatsValue(reports,
                                   StatsReport::kStatsValueNameFramesDecoded));
+  EXPECT_EQ(rtc::ToString(video_receiver_info.frames_rendered),
+            ExtractSsrcStatsValue(reports,
+                                  StatsReport::kStatsValueNameFramesRendered));
   EXPECT_EQ(rtc::ToString(*video_receiver_info.qp_sum),
             ExtractSsrcStatsValue(reports, StatsReport::kStatsValueNameQpSum));
 }