zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix lint errors to enable stricter PyLint rules

Browse Source 
These fixes are needed to avoid errors after submitting
https://codereview.webrtc.org/2737963003

BUG=webrtc:7303
NOTRY=True

Review-Url: https://codereview.webrtc.org/2812273002
Cr-Commit-Position: refs/heads/master@{#17679}
This commit is contained in:
kjellander
2017-04-12 12:06:13 -07:00
committed by Commit bot
parent 06034c7d64
commit dd460e2aa2
19 changed files with 196 additions and 190 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tools-webrtc/ios/generate_licenses.py
View File

@ -37,16 +37,18 @@ SCRIPT_DIR = os.path.dirname(os.path.realpath(sys.argv[0]))
CHECKOUT_ROOT = os.path.abspath(os.path.join(SCRIPT_DIR, os.pardir, os.pardir))
WEBRTC_ROOT = os.path.join(CHECKOUT_ROOT, 'webrtc')
def GetThirdPartyLibraries(buildfile_dir, target_name):
def extractLibName(s):
def ExtractLibName(string_list):
# Sample input:
# [" //third_party/usrsctp:usrsctp", " //webrtc:webrtc_common"]
# Sample output:
# ["usrsctp"]
return re.sub(r'\(.*\)', '', s).strip().split(os.path.sep)[-1].split(':')[0]
return re.sub(r'\(.*\)', '', string_list).strip().split(
os.path.sep)[-1].split(':')[0]
output = subprocess.check_output(
["gn", "desc", buildfile_dir, target_name, '--all']) .split(os.linesep)
return [extractLibName(x) for x in output if re.search(r'third_party', x)]
return [ExtractLibName(x) for x in output if re.search(r'third_party', x)]
class LicenseBuilder(object):
@ -112,7 +114,7 @@ class LicenseBuilder(object):
return 0
if __name__ == '__main__':
def main():
parser = argparse.ArgumentParser(description='Generate WebRTC LICENSE.html')
parser.add_argument('target_name',
help='Name of the GN target to generate a license for')
@ -123,3 +125,7 @@ if __name__ == '__main__':
args = parser.parse_args()
builder = LicenseBuilder(args.buildfile_dirs, args.target_name)
sys.exit(builder.GenerateLicenseText(args.output_dir))
if __name__ == '__main__':
main()