zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

rename "sdp" to description in a few places

Browse Source 
renames the RTCSessionDescription object from "ѕdp" to "desc" in a few places.
The term SDP should generally refer to the blob of text described in
RFC 4566 while the RTCSessionDescription specified in
  https://w3c.github.io/webrtc-pc/#rtcsessiondescription-class
contains both a type and a sdp.

BUG=None

Change-Id: Iacf332d02b03134e49c2b4147dc5725affa89741
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183882
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Tommi <tommi@webrtc.org>
Commit-Queue: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32080}
This commit is contained in:
Philipp Hancke
2020-09-10 17:22:16 +02:00
committed by Commit Bot
parent 3dc4780d8e
commit dd68063976
6 changed files with 73 additions and 76 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
examples/androidapp/src/org/appspot/apprtc/CallActivity.java
View File

@ -786,7 +786,7 @@ public class CallActivity extends Activity implements AppRTCClient.SignalingEven
}
@Override
public void onRemoteDescription(final SessionDescription sdp) {
public void onRemoteDescription(final SessionDescription desc) {
final long delta = System.currentTimeMillis() - callStartedTimeMs;
runOnUiThread(new Runnable() {
@Override
@ -795,8 +795,8 @@ public class CallActivity extends Activity implements AppRTCClient.SignalingEven
Log.e(TAG, "Received remote SDP for non-initilized peer connection.");
return;
}
logAndToast("Received remote " + sdp.type + ", delay=" + delta + "ms");
peerConnectionClient.setRemoteDescription(sdp);
logAndToast("Received remote " + desc.type + ", delay=" + delta + "ms");
peerConnectionClient.setRemoteDescription(desc);
if (!signalingParameters.initiator) {
logAndToast("Creating ANSWER...");
// Create answer. Answer SDP will be sent to offering client in
@ -856,17 +856,17 @@ public class CallActivity extends Activity implements AppRTCClient.SignalingEven
// All callbacks are invoked from peer connection client looper thread and
// are routed to UI thread.
@Override
public void onLocalDescription(final SessionDescription sdp) {
public void onLocalDescription(final SessionDescription desc) {
final long delta = System.currentTimeMillis() - callStartedTimeMs;
runOnUiThread(new Runnable() {
@Override
public void run() {
if (appRtcClient != null) {
logAndToast("Sending " + sdp.type + ", delay=" + delta + "ms");
logAndToast("Sending " + desc.type + ", delay=" + delta + "ms");
if (signalingParameters.initiator) {
appRtcClient.sendOfferSdp(sdp);
appRtcClient.sendOfferSdp(desc);
} else {
appRtcClient.sendAnswerSdp(sdp);
appRtcClient.sendAnswerSdp(desc);
}
}
if (peerConnectionParameters.videoMaxBitrate > 0) {