zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete macros RTC_DISALLOW_ASSIGN and RTC_DISALLOW_IMPLICIT_CONSTRUCTORS

Browse Source 
The former was unused, the latter is replaced with the explicit C++11
deletions. The related RTC_DISALLOW_COPY_AND_ASSIGN is left for now,
it is used in a lot more places.

Bug: None
Change-Id: I49503e7f2b9ff43c6285f8695833479bbc18c380
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/185500
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#32224}
This commit is contained in:
Niels Möller
2020-09-29 09:46:21 +02:00
committed by Commit Bot
parent 46be80d349
commit de95329daa
55 changed files with 256 additions and 172 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
modules/congestion_controller/goog_cc/BUILD.gn
View File

@ -44,7 +44,6 @@ rtc_library("goog_cc") {
"../../../logging:rtc_event_pacing",
"../../../rtc_base:checks",
"../../../rtc_base:logging",
"../../../rtc_base:macromagic",
"../../../rtc_base/experiments:alr_experiment",
"../../../rtc_base/experiments:field_trial_parser",
"../../../rtc_base/experiments:rate_control_settings",

7
modules/congestion_controller/goog_cc/delay_based_bwe.h
View File

@ -26,7 +26,6 @@
#include "modules/remote_bitrate_estimator/aimd_rate_control.h"
#include "modules/remote_bitrate_estimator/include/bwe_defines.h"
#include "modules/remote_bitrate_estimator/inter_arrival.h"
#include "rtc_base/constructor_magic.h"
#include "rtc_base/experiments/struct_parameters_parser.h"
#include "rtc_base/race_checker.h"
@ -78,6 +77,11 @@ class DelayBasedBwe {
explicit DelayBasedBwe(const WebRtcKeyValueConfig* key_value_config,
RtcEventLog* event_log,
NetworkStatePredictor* network_state_predictor);
DelayBasedBwe() = delete;
DelayBasedBwe(const DelayBasedBwe&) = delete;
DelayBasedBwe& operator=(const DelayBasedBwe&) = delete;
virtual ~DelayBasedBwe();
Result IncomingPacketFeedbackVector(
@ -143,7 +147,6 @@ class DelayBasedBwe {
bool has_once_detected_overuse_;
BandwidthUsage prev_state_;
bool alr_limited_backoff_enabled_;
RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(DelayBasedBwe);
};
} // namespace webrtc

8
modules/congestion_controller/goog_cc/goog_cc_network_control.h
View File

@ -33,7 +33,6 @@
#include "modules/congestion_controller/goog_cc/delay_based_bwe.h"
#include "modules/congestion_controller/goog_cc/probe_controller.h"
#include "modules/congestion_controller/goog_cc/send_side_bandwidth_estimation.h"
#include "rtc_base/constructor_magic.h"
#include "rtc_base/experiments/field_trial_parser.h"
#include "rtc_base/experiments/rate_control_settings.h"
@ -48,6 +47,11 @@ class GoogCcNetworkController : public NetworkControllerInterface {
public:
GoogCcNetworkController(NetworkControllerConfig config,
GoogCcConfig goog_cc_config);
GoogCcNetworkController() = delete;
GoogCcNetworkController(const GoogCcNetworkController&) = delete;
GoogCcNetworkController& operator=(const GoogCcNetworkController&) = delete;
~GoogCcNetworkController() override;
// NetworkControllerInterface
@ -137,8 +141,6 @@ class GoogCcNetworkController : public NetworkControllerInterface {
bool previously_in_alr_ = false;
absl::optional<DataSize> current_data_window_;
RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(GoogCcNetworkController);
};
} // namespace webrtc