zqz/platform-external-webrtc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete obsolete RtcEventLogOutputFile constructor

Browse Source 
Followup to https://webrtc-review.googlesource.com/c/src/+/134460.

Bug: webrtc:6463
Change-Id: Ib6574b02b21fddc598c1f67c7e2b515f01d33204
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/139887
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Commit-Queue: Niels Moller <nisse@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#28206}
This commit is contained in:
Niels Möller
2019-06-03 15:25:20 +02:00
committed by Commit Bot
parent 12561e06ce
commit dec9f74b8d
5 changed files with 18 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
api/rtc_event_log_output_file.cc
View File

@ -18,17 +18,6 @@
namespace webrtc {
namespace {
FileWrapper FileWrapperFromPlatformFile(rtc::PlatformFile platform_file) {
if (platform_file == rtc::kInvalidPlatformFileValue)
return FileWrapper();
return FileWrapper(rtc::FdopenPlatformFileForWriting(platform_file));
}
} // namespace
// Together with the assumption of no single Write() would ever be called on
// an input with length greater-than-or-equal-to (max(size_t) / 2), this
// guarantees no overflow of the check for remaining file capacity in Write().
@ -60,11 +49,6 @@ RtcEventLogOutputFile::RtcEventLogOutputFile(FileWrapper file,
}
}
RtcEventLogOutputFile::RtcEventLogOutputFile(rtc::PlatformFile platform_file,
size_t max_size_bytes)
: RtcEventLogOutputFile(FileWrapperFromPlatformFile(platform_file),
max_size_bytes) {}
bool RtcEventLogOutputFile::IsActive() const {
return IsActiveInternal();
}

5
api/rtc_event_log_output_file.h
View File

@ -16,7 +16,6 @@
#include <string>
#include "api/rtc_event_log_output.h"
#include "rtc_base/platform_file.h" // Can't neatly forward PlatformFile.
#include "rtc_base/system/file_wrapper.h"
namespace webrtc {
@ -33,10 +32,6 @@ class RtcEventLogOutputFile final : public RtcEventLogOutput {
// of the FILE*, and closes it on destruction.
RtcEventLogOutputFile(FILE* file, size_t max_size_bytes);
// TODO(bugs.webrtc.org/6463): Deprecated, delete together with the
// corresponding PeerConnection::StartRtcEventLog override.
RtcEventLogOutputFile(rtc::PlatformFile file, size_t max_size_bytes);
~RtcEventLogOutputFile() override = default;
bool IsActive() const override;